Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions __tests__/LaunchDarklyProvider.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { OpenFeature, Client } from '@openfeature/js-sdk';
import { OpenFeature, Client, ErrorCode } from '@openfeature/js-sdk';
import { LDClient } from 'launchdarkly-node-server-sdk';
import { LaunchDarklyProvider } from '../src';
import translateContext from '../src/translateContext';
Expand Down Expand Up @@ -210,12 +210,12 @@ describe('given a mock LaunchDarkly client', () => {
});

it.each([
['CLIENT_NOT_READY', 'PROVIDER_NOT_READY'],
['MALFORMED_FLAG', 'PARSE_ERROR'],
['FLAG_NOT_FOUND', 'FLAG_NOT_FOUND'],
['USER_NOT_SPECIFIED', 'GENERAL'],
['UNSPECIFIED', 'GENERAL'],
[undefined, 'GENERAL'],
['CLIENT_NOT_READY', ErrorCode.PROVIDER_NOT_READY],
['MALFORMED_FLAG', ErrorCode.PARSE_ERROR],
['FLAG_NOT_FOUND', ErrorCode.FLAG_NOT_FOUND],
['USER_NOT_SPECIFIED', ErrorCode.TARGETING_KEY_MISSING],
['UNSPECIFIED', ErrorCode.GENERAL],
[undefined, ErrorCode.GENERAL],
])('handles errors from the client', async (ldError, ofError) => {
ldClient.variationDetail = jest.fn(async () => ({
value: { yes: 'no' },
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"launchdarkly-node-server-sdk": "6.x"
},
"devDependencies": {
"@openfeature/js-sdk": "0.4.0",
"@openfeature/js-sdk": "0.5.0",
"@types/jest": "^27.4.1",
"@typescript-eslint/eslint-plugin": "^5.22.0",
"@typescript-eslint/parser": "^5.22.0",
Expand Down
7 changes: 4 additions & 3 deletions src/LaunchDarklyProvider.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import {
ErrorCode,
EvaluationContext, FlagValue, Hook,
JsonValue,
Provider, ProviderMetadata, ResolutionDetails,
Provider, ProviderMetadata, ResolutionDetails, StandardResolutionReasons,
} from '@openfeature/js-sdk';
import {
basicLogger, LDClient, LDLogger,
Expand All @@ -19,8 +20,8 @@ import translateResult from './translateResult';
function wrongTypeResult<T>(value: T): ResolutionDetails<T> {
return {
value,
reason: 'ERROR',
errorCode: 'TYPE_MISMATCH',
reason: StandardResolutionReasons.ERROR,
errorCode: ErrorCode.TYPE_MISMATCH,
};
}

Expand Down
15 changes: 8 additions & 7 deletions src/translateResult.ts
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
import { ResolutionDetails } from '@openfeature/js-sdk';
import { ErrorCode, ResolutionDetails } from '@openfeature/js-sdk';
import { LDEvaluationDetail } from 'launchdarkly-node-server-sdk';

/**
* Convert an `errorKind` into an OpenFeature `errorCode`.
* @param {string} errorKind The error kind to translate.
* @returns {string} The OpenFeature error code.
*/
function translateErrorKind(errorKind) {
function translateErrorKind(errorKind): ErrorCode {
// Error code specification.
// https://github.com/open-feature/spec/blob/main/specification/sections/02-providers.md#requirement-28
switch (errorKind) {
case 'CLIENT_NOT_READY':
return 'PROVIDER_NOT_READY';
return ErrorCode.PROVIDER_NOT_READY;
case 'MALFORMED_FLAG':
return 'PARSE_ERROR';
return ErrorCode.PARSE_ERROR;
case 'FLAG_NOT_FOUND':
return 'FLAG_NOT_FOUND';
return ErrorCode.FLAG_NOT_FOUND;
case 'USER_NOT_SPECIFIED':
return ErrorCode.TARGETING_KEY_MISSING;
// General errors.
// 'USER_NOT_SPECIFIED' also falls through to default.
default:
return 'GENERAL';
return ErrorCode.GENERAL;
}
}

Expand Down