-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Is your feature request related to a problem? Please describe.
When initialising the LaunchDarklyProvider it currently requires passing the Config type declared in a third party package (ldclient), which means that in order to not cause type checking issues you have to either:
- directly depend on the
ldclientpackage solely to init the provider - rely on the transitive dependency and assume this package will never remove the dependency
- provide an object that is structurally equivalent to Config and instruct the type checker to ignore the error
Describe the solution you'd like
Re-exporting the Config type like FastAPI does with many starlette types, e.g. status so consumers can use the transitively dependent type.
Describe alternatives you've considered
- Define an internal type within this package, e.g.:
- A new local
Configtype that only contains a subset of upstream properties that are solely required for this provider to work. - A new local
configconstructor param could just be of typedict[str, Any]that is deconstructed directly toldclient.Configinternally. - Constructor could just take required args as well as
**kwargsand then everything else is proxied toldclient.Configinternally using thekwargs.
- A new local
Additional context
N/A
ismailmo1
Metadata
Metadata
Assignees
Labels
No labels