prepare 3.5.3 release #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix version string
add new version of allFlags() that captures more metadata
add ability to filter for client-side flags only
implement evaluation with explanations
cache flag data in allFlags
# Conflicts: # src/LaunchDarkly/LDClient.php
add option to reduce front-end metadata for untracked flags
simplify & move feature requester/event publisher code
* add step to wait on Consul
…ithout valid users
…ttrs coerce user attributes to strings when necessary, don't send events without valid users
add release script (version update only)
add param to skip db tests, update docs for new repo name
…ests add tests for rollout calculations, + misc test cleanup
bwoskow-ld
requested changes
Apr 26, 2019
CONTRIBUTING.md
Outdated
| @@ -1,4 +1,37 @@ | |||
| Contributing to the LaunchDarkly SDK for PHP | |||
| ================================================ | |||
| # Contributing to the LaunchDarkly SDK FOR PHP | |||
There was a problem hiding this comment.
Also, the title should have "Server-side" in it.
CONTRIBUTING.md
Outdated
|
|
||
| ## Submitting bug reports and feature requests | ||
|
|
||
| The LaunchDarkly SDK team monitors the issue tracker associated with the `launchdarkly/php-server-sdk` SDK repository. Bug reports and feature requests specific to this SDK should be filed in this issue tracker. The SDK team will respond to all newly filed issues within two business days. |
There was a problem hiding this comment.
In my other pull requests I linked to the issue tracker and then just said "... with the SDK repository" since the link made it clear to which SDK repository I was referring. It would be good to include a link here too.
| ## Getting started | ||
|
|
||
| require 'vendor/autoload.php'; | ||
| Refer to the [SDK reference guide](https://docs.launchdarkly.com/docs/php-sdk-reference) for instructions on getting started with using the SDK. |
There was a problem hiding this comment.
You may as well include the section anchor: https://docs.launchdarkly.com/docs/php-sdk-reference#section-getting-started
bwoskow-ld
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[3.5.3] - 2019-04-26
Fixed:
key; all users would end up in the same bucket. (Thanks, m6w6!)CONTRIBUTING.md.Note on future releases
The LaunchDarkly SDK repositories are being renamed for consistency. This repository is now
php-server-sdkrather thanphp-client.The package name will also change. In the 3.5.3 release, it is still
launchdarkly/launchdarkly-php; in all future releases, it will belaunchdarkly/server-sdk. No further updates to thelaunchdarkly/launchdarkly-phppackage will be published after this release.