Skip to content

Send the default value back to LD #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Send the default value back to LD #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/LaunchDarkly/LDClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,17 @@ public function toggle($key, $user, $default = false) {
$flag = $this->_toggle($key, $user);

if (is_null($flag)) {
$this->_sendFlagRequestEvent($key, $user, $default);
$this->_sendFlagRequestEvent($key, $user, $default, $default);
return $default;
}
else {
$this->_sendFlagRequestEvent($key, $user, $flag);
$this->_sendFlagRequestEvent($key, $user, $flag, $default);
return $flag;
}
} catch (\Exception $e) {
error_log("LaunchDarkly caught $e");
try {
$this->_sendFlagRequestEvent($key, $user, $default);
$this->_sendFlagRequestEvent($key, $user, $default, $default);
}
catch (\Exception $e) {
error_log("LaunchDarkly caught $e");
Expand Down Expand Up @@ -178,7 +178,7 @@ public function identify($user) {
* @param $user LDUser
* @param $value mixed
*/
protected function _sendFlagRequestEvent($key, $user, $value) {
protected function _sendFlagRequestEvent($key, $user, $value, $default) {
if ($this->isOffline() || !$this->_events) {
return;
}
Expand All @@ -189,6 +189,7 @@ protected function _sendFlagRequestEvent($key, $user, $value) {
$event['kind'] = "feature";
$event['creationDate'] = round(microtime(1) * 1000);
$event['key'] = $key;
$event['default'] = $default;
$this->_eventProcessor->enqueue($event);
}

Expand Down