Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
Contributing to the LaunchDarkly SDK for PHP
================================================

We encourage pull-requests and other contributions from the community. We've also published an [SDK contributor's guide](http://docs.launchdarkly.com/v1.0/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work.
We encourage pull-requests and other contributions from the community. We've also published an [SDK contributor's guide](http://docs.launchdarkly.com/v1.0/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work.


This can help with getting php 5.3 on your mac: https://github.com/Homebrew/homebrew-php

To see composer dependency graph:
`php composer.phar show -i -t`
5 changes: 4 additions & 1 deletion circle.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
machine:
php:
version: 5.4.37
version: 5.3.25
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest php version that CircleCI gives us.


test:
override:
# syntax check php files
- find ./src -name "*.php" -type f -print0 | xargs -0 -I {} php -l {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'compile' step to ensure php 5.3 compatibility in case tests don't have 100% code coverage

- find ./tests -name "*.php" -type f -print0 | xargs -0 -I {} php -l {}
- vendor/bin/phpunit tests
5 changes: 3 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@
}
],
"require": {
"php": ">=5.3",
"php": "~5.3",
"guzzle/guzzle": "dev-master#ecb935d2d0ecd8cddae4dcfb90515cac5e2cb023",
"psr/log": "1.0.0"
"psr/log": "1.0.0",
"justinrainbow/json-schema": "v1.6.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a transitive dependency, but the version is not pinned, and by default composer will bring in a version that is too high to be compatible with 5.3.25. This is the highest version compatible with 5.3.25

},
"require-dev": {
"phpunit/phpunit": "4.8.26",
Expand Down
Loading