-
Notifications
You must be signed in to change notification settings - Fork 48
Fix PHP 5.3 incompatibilities #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
462707f
b30fc18
4301b29
1736368
3b67e17
a71e1f4
0f39b53
ad886a9
8d92279
7945de9
9288170
90b52a6
3b69e23
25f0e9d
b41ad3a
3efd07e
f3a4007
ef206de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,10 @@ | ||
| Contributing to the LaunchDarkly SDK for PHP | ||
| ================================================ | ||
|
|
||
| We encourage pull-requests and other contributions from the community. We've also published an [SDK contributor's guide](http://docs.launchdarkly.com/v1.0/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work. | ||
| We encourage pull-requests and other contributions from the community. We've also published an [SDK contributor's guide](http://docs.launchdarkly.com/v1.0/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work. | ||
|
|
||
|
|
||
| This can help with getting php 5.3 on your mac: https://github.com/Homebrew/homebrew-php | ||
|
|
||
| To see composer dependency graph: | ||
| `php composer.phar show -i -t` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| machine: | ||
| php: | ||
| version: 5.4.37 | ||
| version: 5.3.25 | ||
|
|
||
| test: | ||
| override: | ||
| # syntax check php files | ||
| - find ./src -name "*.php" -type f -print0 | xargs -0 -I {} php -l {} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 'compile' step to ensure php 5.3 compatibility in case tests don't have 100% code coverage |
||
| - find ./tests -name "*.php" -type f -print0 | xargs -0 -I {} php -l {} | ||
| - vendor/bin/phpunit tests | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,9 +20,10 @@ | |
| } | ||
| ], | ||
| "require": { | ||
| "php": ">=5.3", | ||
| "php": "~5.3", | ||
| "guzzle/guzzle": "dev-master#ecb935d2d0ecd8cddae4dcfb90515cac5e2cb023", | ||
| "psr/log": "1.0.0" | ||
| "psr/log": "1.0.0", | ||
| "justinrainbow/json-schema": "v1.6.0" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a transitive dependency, but the version is not pinned, and by default composer will bring in a version that is too high to be compatible with 5.3.25. This is the highest version compatible with 5.3.25 |
||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "4.8.26", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest php version that CircleCI gives us.