feat: adds ability to use inverted judges#168
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a8f14de. Configure here.
| score = result.score | ||
| if optimization_judge.threshold is not None: | ||
| passed = score >= optimization_judge.threshold | ||
| passed = judge_passed(score, optimization_judge.threshold, optimization_judge.is_inverted) |
There was a problem hiding this comment.
Inverted judge logic missed in fallback threshold branch
Medium Severity
In variation_prompt_feedback, the else branch (when optimization_judge.threshold is None) still uses passed = score >= 1.0 instead of calling judge_passed(score, 1.0, optimization_judge.is_inverted). For inverted judges hitting this path, a low score (which should pass) would be marked as FAILED, and only a perfect 1.0 would pass — the exact opposite of the intended behavior. The other two equivalent locations in client.py correctly default to 1.0 and pass it through judge_passed.
Reviewed by Cursor Bugbot for commit a8f14de. Configure here.
23baeb4
into
aklatzke/AIC-2263/sdk-dx-improvements
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-server-sdk-ai: 1.2.0</summary> ## [1.2.0](launchdarkly-server-sdk-ai-1.1.0...launchdarkly-server-sdk-ai-1.2.0) (2026-07-17) ### Features * implements template/raw methods for fetching configs ([1c06d35](1c06d35)) * implements template/raw methods for fetching configs ([#204](#204)) ([5106866](5106866)) </details> <details><summary>ldai_optimizer: 0.2.0</summary> ## [0.2.0](ldai_optimizer-0.1.0...ldai_optimizer-0.2.0) (2026-07-17) ### ⚠ BREAKING CHANGES * Bump minimum LangChain version to 1.0.0 ### Features * ability to specify variation key on config or from_options for optimization package ([c5e39eb](c5e39eb)) * ability to specify variation key on config or from_options for optimization package ([#162](#162)) ([f0c4612](f0c4612)) * add auto-commit option ([4cb8859](4cb8859)) * add optimization for duration ([5d76276](5d76276)) * Add optimization package stub ([#109](#109)) ([ebd5166](ebd5166)) * add shared dataclass for calls so they can be handled by same handler ([31c8385](31c8385)) * add token limit handling ([e8c6692](e8c6692)) * adds ability to optimize for cost ([94de596](94de596)) * adds ability to optimize for cost ([#172](#172)) ([3b4baa3](3b4baa3)) * adds ability to use inverted judges ([0ed243e](0ed243e)) * adds ability to use inverted judges ([#168](#168)) ([23baeb4](23baeb4)) * Adds optimization package stub ([58b7731](58b7731)) * Adds optimization package stub ([cc85a05](cc85a05)) * adds reporting for cost and latency optimization failures ([365fa94](365fa94)) * adds reporting for cost and latency optimization failures ([#180](#180)) ([d267832](d267832)) * all logs -> debug ([2fd55e2](2fd55e2)) * Bump minimum LangChain version to 1.0.0 ([dc592c5](dc592c5)) * Drop support for python 3.9 ([#114](#114)) ([dc592c5](dc592c5)) * dx improvements for optimization package ([7074cfa](7074cfa)) * ground truth optimization path ([44c8c59](44c8c59)) * implement ability to use completions or agents for judge calls ([ea596a7](ea596a7)) * implement additional config optimization api fields ([#196](#196)) ([4ed30d8](4ed30d8)) * implement latency & token tracking for optimizations ([288336e](288336e)) * Implement optimization code paths and functionality for initial release ([#140](#140)) ([5204c47](5204c47)) * implementation of agent optimization + tests ([1712e4f](1712e4f)) * implements LD API client, optimize_from_config path ([2fecd54](2fecd54)) * implements optimize method in SDK, code moved ([9859d08](9859d08)) * partially implement optimize_from_config ([d3e1f96](d3e1f96)) * prevent overfitting via prompt changes and post-processing ([8f9f1e2](8f9f1e2)) * use judge_passed for all calcs ([a8f14de](a8f14de)) ### Bug Fixes * address cursor feedback ([f2f0894](f2f0894)) * adjust iteration logic so validation doesn't consume them ([3042984](3042984)) * better handling of params and custom params for optimization ([572a2aa](572a2aa)) * better handling of params and custom params for optimization ([#163](#163)) ([92f51fa](92f51fa)) * consistency with other makefiles ([b9a5601](b9a5601)) * don't only evaluate final input in GT results ([53f455f](53f455f)) * don't only evaluate final input in GT results ([9bedf9e](9bedf9e)) * ensure cost data is persisted ([4eb0bb0](4eb0bb0)) * fix for single-iteration optimizations ([96eadb7](96eadb7)) * fix for single-iteration optimizations ([#209](#209)) ([ba5aa63](ba5aa63)) * lint ([aee6aa7](aee6aa7)) * lint + missed variable rename ([f8e5509](f8e5509)) * lints + structured output tool rename ([8481690](8481690)) * move failure forward ([3c65a6e](3c65a6e)) * only strip known provider prefixes ([66bc1f0](66bc1f0)) * **optimization:** address Bugbot comments on PR [#140](#140) ([9e57d86](9e57d86)) * **optimization:** fix CI test failures and apply Bugbot-reported fixes ([ffad0cb](ffad0cb)) * **optimization:** match model config by key as well as id for pricing lookup ([a8415be](a8415be)) * **optimization:** remove dead persistence counter code ([c76cb16](c76cb16)) * **optimization:** retry LLM calls on transient provider errors (429/503/529) ([a131e4b](a131e4b)) * **optimization:** use run-chosen context for config judges; guard non-dict JSON ([64e12f2](64e12f2)) * pull model configs if available in options path ([4fc1ecf](4fc1ecf)) * remove unnecessary token path ([dc82818](dc82818)) * sort imports ([c032aaf](c032aaf)) * success path + add test, cursor feedback ([8f3468f](8f3468f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Mechanical version, changelog, and dependency-floor updates from Release Please; no runtime code changes in this PR. > > **Overview** > **Release Please** version bump only—no application logic changes in this diff. > > **`launchdarkly-server-sdk-ai` 1.2.0** — `pyproject.toml`, `ldai.__version__`, changelog, and provenance docs move from **1.1.0 → 1.2.0**. The new changelog section documents **template/raw config fetch APIs** (shipped in prior commits, e.g. `completion_config_template`). > > **`launchdarkly-ai-optimizer` 0.2.0** — same pattern (**0.1.0 → 0.2.0**) with an expanded **CHANGELOG** (including **LangChain ≥ 1.0** as a breaking note for optimizer consumers). > > **Provider packages** — `launchdarkly-server-sdk-ai-langchain` and `launchdarkly-server-sdk-ai-openai` now require **`launchdarkly-server-sdk-ai>=1.2.0`** instead of **≥1.1.0**. > > **`.release-please-manifest.json`** is updated to match the new package versions. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e86bad4. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->


Requirements
Describe the solution you've provided
Implements handling for "inverted" judges.
Describe alternatives you've considered
This gets feature parity with our online evals functionality; no alternatives considered.
Additional context
When a metric has
is_invertedset, it's intended that the evaluation of the score flips from>=to<=. This adds a util_judge_passedto handle that logic and implements it throughout. We don't surface the inverted property in the SDK, so we fetch the judge directly to get this information.Note
Medium Risk
Changes core judge pass/fail semantics and adds per-judge REST calls (
get_ai_config) during config-driven runs, which could affect optimization outcomes and introduce new failure/performance modes if the API is unavailable or slow.Overview
Adds first-class support for inverted judges (where lower scores are better) by introducing a shared
judge_passedhelper and using it for pass/fail decisions inOptimizationClientand in prompt feedback generation.Extends
OptimizationJudgewith anis_invertedflag and, foroptimize_from_config, fetches each judge’sisInvertedvalue viaapi_client.get_ai_configwhen building options. Updates logging to include the inverted status, and adds targeted tests covering the helper, mixed inverted/standard evaluation, config building behavior, andvariation_prompt_feedbackoutput.Reviewed by Cursor Bugbot for commit a8f14de. Bugbot is set up for automated code reviews on this repo. Configure here.