feat: Wire LDAIMetrics tool_calls and duration_ms into tracker#152
Draft
jsonbailey wants to merge 1 commit intojb/aic-2388/managed-graph-resultfrom
Draft
feat: Wire LDAIMetrics tool_calls and duration_ms into tracker#152jsonbailey wants to merge 1 commit intojb/aic-2388/managed-graph-resultfrom
jsonbailey wants to merge 1 commit intojb/aic-2388/managed-graph-resultfrom
Conversation
jsonbailey
force-pushed
the
jb/aic-2388/enrich-metrics
branch
from
98e3ccc to
cbe2eda
Compare
jsonbailey
changed the title
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins down the contract for the new
tool_callsandduration_msfields onLDAIMetrics. The integration was introduced incrementally as the OpenAI and LangChain runners migrated; this PR adds test coverage that will guard the contract going forward.LDAIMetrics.to_dict()exposestoolCallsanddurationMstrack_metrics_of/track_metrics_of_asyncuse a runner-suppliedduration_msdirectly when present, otherwise measure elapsed wall-clock timetrack_metrics_ofcallstrack_tool_calls()whenmetrics.tool_callsis present, emitting one$ld:ai:tool_callevent per key and recording the list onLDAIMetricSummaryStack
PR 7 → PR 8 → PR 8-openai → PR 8-langchain → PR 9 → PR 10 (this) → PR 11 → PR 11-openai → PR 11-langchain → PR 12
Test plan
make test— 267 tests passmake lint— mypy clean🤖 Generated with Claude Code