Skip to content

fix: parse model.parameters.tools as list#160

Merged
jsonbailey merged 2 commits intomainfrom
jb/aic-1935/list-tools-format
May 5, 2026
Merged

fix: parse model.parameters.tools as list#160
jsonbailey merged 2 commits intomainfrom
jb/aic-1935/list-tools-format

Conversation

@jsonbailey
Copy link
Copy Markdown
Contributor

@jsonbailey jsonbailey commented May 1, 2026

Summary

  • model.parameters.tools wire format is a list of LDTool objects; root-level tools is a dict keyed by tool name. Previously _resolve_tools checked for a dict in both paths, so the model params fallback always returned None.
  • Fixes _resolve_tools to check isinstance(tools_list, list) for the model params path and iterate it to build the tools dict.
  • Removes the _parse_tools and _parse_tools_from_list helpers, inlining the logic. No warnings are emitted — data from the LD API is trusted to be our shape, matching the JS SDK approach.
  • Updates test fixtures and adds/renames tests to cover list format, dict format rejection, and silent skipping of nameless entries.

Test plan

  • uv run pytest tests/test_tools.py — all 11 tools tests pass
  • uv run pytest — all 154 tests pass
  • uv run mypy src/ldai — no type errors

🤖 Generated with Claude Code


Note

Low Risk
Low risk: targeted change to tools parsing that affects only how AI config variations are interpreted; main risk is behavior change for previously accepted/ignored malformed tool shapes.

Overview
Fixes tools parsing for AI configs by updating _resolve_tools in client.py to treat root-level tools as a dict (unchanged behavior) while correctly parsing model.parameters.tools as a list of tool objects.

Adds/updates tests to reflect the list wire format, assert that dict-shaped model.parameters.tools is rejected (returns None), and verify invalid list entries are skipped while valid tools are still parsed.

Reviewed by Cursor Bugbot for commit db79f74. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey jsonbailey marked this pull request as ready for review May 1, 2026 20:58
@jsonbailey jsonbailey requested a review from a team as a code owner May 1, 2026 20:58
Comment thread packages/sdk/server-ai/src/ldai/client.py
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 13e2820. Configure here.

Comment thread packages/sdk/server-ai/src/ldai/client.py
jsonbailey and others added 2 commits May 5, 2026 08:44
The wire format for tools at model.parameters.tools is a list of LDTool
objects, while root-level tools is a dict keyed by tool name. Previously
_resolve_tools treated both as dicts, causing the model params fallback
path to always return None.

Removes helper functions and inlines logic into _resolve_tools with no
warnings, matching the JS implementation approach of trusting the data
shape from the LD API.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Re-adds entry-level warnings that were removed when inlining the parsing
logic. Users setting incorrect defaults would otherwise get silent drops
with no indication of why tools were missing.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jsonbailey jsonbailey force-pushed the jb/aic-1935/list-tools-format branch from 13e2820 to db79f74 Compare May 5, 2026 13:45
@jsonbailey jsonbailey merged commit fb53e99 into main May 5, 2026
45 checks passed
@jsonbailey jsonbailey deleted the jb/aic-1935/list-tools-format branch May 5, 2026 15:16
@github-actions github-actions Bot mentioned this pull request May 5, 2026
jsonbailey added a commit that referenced this pull request May 6, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>launchdarkly-server-sdk-ai: 0.19.0</summary>

##
[0.19.0](launchdarkly-server-sdk-ai-0.18.0...launchdarkly-server-sdk-ai-0.19.0)
(2026-05-05)


### ⚠ BREAKING CHANGES

* StructuredResponse replaced by RunnerResult with new "parsed" property
* AgentResult replaced by RunnerResult and Managed Result
* Removed ModelRunner and AgentRunner protocols
* Removed invoke_method, invoke_structured_model from AIProvider base
class.
* ModelResponse was replaced by RunnerResult
* Add ManagedResult, RunnerResult, and Runner protocol; rename invoke()
to run()
([#148](#148))
* Swap track_metrics_of parameter order to match spec
([#144](#144))

### Features

* Add evaluations support to ManagedAgent.run()
([#153](#153))
([442f46a](442f46a))
* Add judge evaluation support to agent graphs
([#142](#142))
([3d5a6a9](3d5a6a9))
* Add ManagedGraphResult, GraphMetricSummary, and AgentGraphRunnerResult
types
([#151](#151))
([301e24c](301e24c))
* Add ManagedResult, RunnerResult, and Runner protocol; rename invoke()
to run()
([#148](#148))
([88d4ddc](88d4ddc))
* Add root-level tools map with customParameters to AI Config types
([#141](#141))
([f17c535](f17c535))
* bake sampling_rate into Judge at construction; simplify Evaluator to
List[Judge]
([#159](#159))
([86c79e6](86c79e6))
* Update LangChain runners to implement Runner protocol returning
RunnerResult
([#150](#150))
([62a8e25](62a8e25))


### Bug Fixes

* Add runtime DeprecationWarnings to deprecated methods
([#145](#145))
([2189b81](2189b81))
* AgentResult replaced by RunnerResult and Managed Result
([fbb0b4b](fbb0b4b))
* build judge input as string; strip legacy judge config messages
([#165](#165))
([e6942a6](e6942a6))
* Fall back to model.parameters.tools when root tools absent
([#146](#146))
([2c30d75](2c30d75))
* Graph tracking refactor — ManagedAgentGraph drives tracking for new
runner shape
([#154](#154))
([20a5020](20a5020))
* ModelResponse was replaced by RunnerResult
([fbb0b4b](fbb0b4b))
* parse model.parameters.tools as list
([#160](#160))
([fb53e99](fb53e99))
* reference correct PyPI package names in provider load error messages
([#164](#164))
([48761c9](48761c9))
* Removed invoke_method, invoke_structured_model from AIProvider base
class.
([fbb0b4b](fbb0b4b))
* Removed ModelRunner and AgentRunner protocols
([fbb0b4b](fbb0b4b))
* Replace done_callback with coroutine chain for judge tracking
([#147](#147))
([1e1f36b](1e1f36b))
* StructuredResponse replaced by RunnerResult with new "parsed" property
([fbb0b4b](fbb0b4b))
* Swap track_metrics_of parameter order to match spec
([#144](#144))
([53db736](53db736))
</details>

<details><summary>launchdarkly-server-sdk-ai-langchain: 0.6.0</summary>

##
[0.6.0](launchdarkly-server-sdk-ai-langchain-0.5.0...launchdarkly-server-sdk-ai-langchain-0.6.0)
(2026-05-05)


### Features

* Add judge evaluation support to agent graphs
([#142](#142))
([3d5a6a9](3d5a6a9))
* Migrate LangGraph runner to AgentGraphRunnerResult; clean up legacy
shape detection
([#156](#156))
([efa8e00](efa8e00))
* Support conversation history directly in AI Provider model runners
([#166](#166))
([4bb3e78](4bb3e78))
* Update LangChain runners to implement Runner protocol returning
RunnerResult
([#150](#150))
([62a8e25](62a8e25))


### Bug Fixes

* build judge input as string; strip legacy judge config messages
([#165](#165))
([e6942a6](e6942a6))
</details>

<details><summary>launchdarkly-server-sdk-ai-openai: 0.5.0</summary>

##
[0.5.0](launchdarkly-server-sdk-ai-openai-0.4.0...launchdarkly-server-sdk-ai-openai-0.5.0)
(2026-05-05)


### Features

* Add judge evaluation support to agent graphs
([#142](#142))
([3d5a6a9](3d5a6a9))
* Support conversation history directly in AI Provider model runners
([#166](#166))
([4bb3e78](4bb3e78))
* Update OpenAI graph runner to return AgentGraphRunnerResult with
GraphMetrics
([#155](#155))
([388b7af](388b7af))
* Update OpenAI runners to implement Runner protocol returning
RunnerResult
([#149](#149))
([382e662](382e662))


### Bug Fixes

* build judge input as string; strip legacy judge config messages
([#165](#165))
([e6942a6](e6942a6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Primarily a release/version bump, but it publishes **breaking API
changes** (move to unified `Runner.run()`/`RunnerResult` and removal of
`invoke_*` methods), which can break downstream integrations.
> 
> **Overview**
> Cuts a new release across the core SDK and provider packages:
`launchdarkly-server-sdk-ai` to `0.19.0`, LangChain provider to `0.6.0`,
and OpenAI provider to `0.5.0`, updating the release manifest and
package metadata accordingly.
> 
> Changelogs document the shipped breaking API surface changes (notably
removing `invoke_model()`/`invoke_structured_model()` in favor of
`run(...)` and standardizing returns on `RunnerResult`) plus
accompanying feature/fix entries; the core package version
constants/docs (`__version__`, `PROVENANCE.md`) are updated to match.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a20d7a5. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: jsonbailey <jbailey@launchdarkly.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants