Skip to content

fix: Fix overly generic type hint on File data source #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: Fix overly generic type hint on File data source #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ldclient/integrations/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
other than LaunchDarkly.
"""

from typing import Any, Dict, List, Mapping, Optional
from threading import Event
from typing import Any, Callable, Dict, List, Mapping, Optional

from ldclient.config import Config
from ldclient.feature_store import CacheConfig
from ldclient.feature_store_helpers import CachingStoreWrapper
from ldclient.impl.integrations.consul.consul_feature_store import (
Expand All @@ -23,7 +25,7 @@
from ldclient.impl.integrations.redis.redis_feature_store import (
_RedisFeatureStoreCore
)
from ldclient.interfaces import BigSegmentStore
from ldclient.interfaces import BigSegmentStore, FeatureStore, UpdateProcessor


class Consul:
Expand Down Expand Up @@ -206,7 +208,7 @@ class Files:
"""Provides factory methods for integrations with filesystem data."""

@staticmethod
def new_data_source(paths: List[str], auto_update: bool = False, poll_interval: float = 1, force_polling: bool = False) -> object:
def new_data_source(paths: List[str], auto_update: bool = False, poll_interval: float = 1, force_polling: bool = False) -> Optional[Callable[[Config, FeatureStore, Event], UpdateProcessor]]:
"""Provides a way to use local files as a source of feature flag state. This would typically be
used in a test environment, to operate using a predetermined feature flag state without an
actual LaunchDarkly connection.
Expand Down