Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Dec 4, 2025

The new_feature_store and new_big_segment_store methods accept a
max_connections parameter that has been unused since v8.

We cannot start using this parameter now as it would be a functionally
breaking change. Instead, we are opting to warn customers who might try
setting it explicitly.

fixes #386


Note

Warns when non-default max_connections is passed to Redis stores, documents it as unused, and adds tests verifying behavior.

  • Redis integrations:
    • Add warning in Redis.new_feature_store and Redis.new_big_segment_store when max_connections differs from Redis.DEFAULT_MAX_CONNECTIONS; advise using redis_opts={'max_connections': N}.
    • Update docstrings to mark max_connections as deprecated/unused.
    • Import ldclient.log to emit warnings.
  • Tests (ldclient/testing/integrations/test_redis.py):
    • Verify max_connections arg does not affect Redis connection pool for feature store and big segment store.
    • Verify warnings are logged when max_connections is non-default and not when default.

Written by Cursor Bugbot for commit 4e767c5. This will update automatically on new commits. Configure here.

The `new_feature_store` and `new_big_segment_store` methods accept a
`max_connections` parameter that has been unused since v8.

We cannot start using this parameter now as it would be a functionally
breaking change. Instead, we are opting to warn customers who might try
setting it explicitly.

fixes #386
@keelerm84 keelerm84 requested a review from a team as a code owner December 4, 2025 15:04
@keelerm84 keelerm84 merged commit e6395fa into main Dec 4, 2025
16 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1658/max-connections branch December 4, 2025 16:53
keelerm84 pushed a commit that referenced this pull request Dec 4, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.14.0](9.13.1...9.14.0)
(2025-12-04)


### Features

* adding data system option to create file datasource intializer
([e5b121f](e5b121f))
* adding file data source as an intializer
([#381](#381))
([3700d1d](3700d1d))


### Bug Fixes

* Add warning if relying on Redis `max_connections` parameter
([#387](#387))
([e6395fa](e6395fa)),
closes
[#386](#386)
* modified initializer behavior to spec
([064f65c](064f65c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

max_connections does nothing

3 participants