fix: Add warning if relying on Redis max_connections parameter
#387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
new_feature_storeandnew_big_segment_storemethods accept amax_connectionsparameter that has been unused since v8.We cannot start using this parameter now as it would be a functionally
breaking change. Instead, we are opting to warn customers who might try
setting it explicitly.
fixes #386
Note
Warns when non-default
max_connectionsis passed to Redis stores, documents it as unused, and adds tests verifying behavior.Redis.new_feature_storeandRedis.new_big_segment_storewhenmax_connectionsdiffers fromRedis.DEFAULT_MAX_CONNECTIONS; advise usingredis_opts={'max_connections': N}.max_connectionsas deprecated/unused.ldclient.logto emit warnings.ldclient/testing/integrations/test_redis.py):max_connectionsarg does not affect Redis connection pool for feature store and big segment store.max_connectionsis non-default and not when default.Written by Cursor Bugbot for commit 4e767c5. This will update automatically on new commits. Configure here.