fix: update launchdarkly-js-client-sdk to ^3.9.4#413
Merged
Conversation
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
joker23
marked this pull request as ready for review
July 21, 2026 13:29
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
tanderson-ld
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Propagates the
launchdarkly-js-sdk-commonv5.8.2 bugfix into the React SDK vialaunchdarkly-js-client-sdk3.9.4 (released to pick up common 5.8.2 — launchdarkly/js-client-sdk#349).Describe the solution you've provided
Raise the
launchdarkly-js-client-sdkfloor from^3.9.3to^3.9.4.The existing caret range already resolves 3.9.4 on a fresh install; this raises the minimum so the fix (common 5.8.2, pulled in transitively by js-client-sdk 3.9.4) is guaranteed. Verified locally against 3.9.4:
npm test(93 passed),npm run lint, andnpm run check-typescriptall pass.Describe alternatives you've considered
Leaving the range at
^3.9.3— it already permits 3.9.4, but does not guarantee the minimum, so the floor bump is preferred.Additional context
Part of rolling out
launchdarkly-js-sdk-commonv5.8.2 across the client-side JS SDKs. Companion PRs: js-client-sdk#349 (merged), node-client-sdk#72 (merged), vue-client-sdk#85.Link to Devin session: https://app.devin.ai/sessions/3ed6e570c11b4abb80724e0f2bc5f03e
Requested by: @joker23
Note
Low Risk
Single dependency floor bump with no application code changes; behavior change comes only from the upstream client/common SDK patch.
Overview
Raises the
launchdarkly-js-client-sdkdependency floor from^3.9.3to^3.9.4so installs always pick up js-client-sdk 3.9.4, which transitively includeslaunchdarkly-js-sdk-commonv5.8.2.This is a dependency-only change (no React SDK source updates); it aligns this package with the same common-SDK bugfix rollout as the other client SDK PRs.
Reviewed by Cursor Bugbot for commit 0feccc7. Bugbot is set up for automated code reviews on this repo. Configure here.