chore: Allow OS to assign port for unit tests #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we started looking for testing ports starting at 5000. If the
port was in use, we would incrementally search upwards until we found a
port we could use.
A recent change in the GH Windows image resulted in a permission error
being raised before we could find a port to use:
To address this, we are modifying the tests to set a port of 0, which
will allow the OS to assign an available port for us. This removes the
need for this silly retry logic and hard coded port numbers.
Note
Switch StubHTTPServer to OS-assigned ephemeral ports and set CI matrix fail-fast to false.
Port: 0
inspec/http_util.rb
and capturing actual port fromserver.config[:Port]
.@@next_port
/self.next_port
helpers; simplifycreate_server
signature.jobs.build-linux.strategy
of.github/workflows/ci.yml
.Written by Cursor Bugbot for commit b1a8f9c. This will update automatically on new commits. Configure here.