Skip to content

chore: Allow OS to assign port for unit tests #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

chore: Allow OS to assign port for unit tests #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
build-linux:
uses: ./.github/workflows/build-gem.yml
strategy:
fail-fast: false
matrix:
version: ["3.2", "jruby-9.4"]
with:
Expand Down
37 changes: 13 additions & 24 deletions spec/http_util.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,36 +7,25 @@
class StubHTTPServer
attr_reader :requests, :port

@@next_port = 50000

def initialize(enable_compression: false)
@port = StubHTTPServer.next_port
@enable_compression = enable_compression
begin
base_opts = {
BindAddress: '127.0.0.1',
Port: @port,
AccessLog: [],
Logger: NullLogger.new,
RequestCallback: method(:record_request),
}
@server = create_server(@port, base_opts)
rescue Errno::EADDRINUSE
@port = StubHTTPServer.next_port
retry
end
base_opts = {
BindAddress: '127.0.0.1',
Port: 0, # Let OS assign an available port
AccessLog: [],
Logger: NullLogger.new,
RequestCallback: method(:record_request),
}
@server = create_server(base_opts)
@requests = []
@requests_queue = Queue.new
end

def self.next_port
p = @@next_port
@@next_port = (p + 1 < 60000) ? p + 1 : 50000
p
end

def create_server(port, base_opts)
WEBrick::HTTPServer.new(base_opts)
def create_server(base_opts)
server = WEBrick::HTTPServer.new(base_opts)
# Get the actual port assigned by the OS
@port = server.config[:Port]
server
end

def start
Expand Down