fix: Fix flag tracker to properly match string keys#370
Merged
jsonbailey merged 4 commits intomainfrom Mar 5, 2026
Merged
Conversation
keelerm84
approved these changes
Mar 4, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
keelerm84
approved these changes
Mar 5, 2026
keelerm84
pushed a commit
that referenced
this pull request
Mar 5, 2026
🤖 I have created a release *beep* *boop* --- ## [8.12.3](8.12.2...8.12.3) (2026-03-05) ### Bug Fixes * Fix flag tracker to properly match string keys ([#370](#370)) ([7e96729](7e96729)) * Move fdv2 data source builders into public API ([#371](#371)) ([c4a1952](c4a1952)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the externally observed type of
flag_change.keyfrom Symbol to String, which may break user listeners that compare against symbols; logic is otherwise narrowly scoped to event construction and test expectations.Overview
Fixes mismatched key types in flag-change events by ensuring
FlagChange.newis always constructed with a string key (item[:key].to_s) in bothimpl/data_source.rbandimpl/data_store/store.rb, so listeners reliably compare against string flag keys.Updates YARD type annotations and FDv2 specs to reflect the string-key behavior (and clarifies that store collections use symbol keys internally).
Written by Cursor Bugbot for commit cd8a51c. This will update automatically on new commits. Configure here.