Skip to content

Conversation

@jsonbailey
Copy link
Contributor

Summary

Updates the SDKVersion JSON schema pattern to allow an optional patch version component. This enables SDK metadata files to specify feature introduction versions with patch precision (e.g., "2.3.1") in addition to the existing major.minor format (e.g., "2.3").

Before: ^[0-9]+\.[0-9]+$ (only "X.Y")
After: ^[0-9]+\.[0-9]+(\.[0-9]+)?$ (allows "X.Y" or "X.Y.Z")

This change is backward compatible - existing major.minor versions continue to validate.

Review & Testing Checklist for Human

  • Verify the regex pattern ^[0-9]+\.[0-9]+(\.[0-9]+)?$ correctly matches intended formats:
    • Should match: "2.3", "5.4", "2.3.1", "10.20.30"
    • Should NOT match: "2", "2.3.1.4", "v2.3", "2.3."
  • Confirm no downstream consumers of this schema expect strictly major.minor format

Notes

This change was requested to support the Ruby Server SDK which has features introduced at specific patch versions (e.g., storingDataRedis at 2.3.1).


Requested by: @jsonbailey
Link to Devin run: https://app.devin.ai/sessions/49b44fe704ac4382802b7b3dc07970a6

Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
@jsonbailey jsonbailey requested a review from a team as a code owner January 16, 2026 22:38
@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@jsonbailey jsonbailey merged commit cf50dc4 into main Jan 16, 2026
4 checks passed
@jsonbailey jsonbailey deleted the devin/1768603028-allow-patch-version branch January 16, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants