pg_catalog.timestamp(0) instead of timestamp(0)

[murashki]

Hello team!

I can’t get a clean output from desparse. Please take a look at these two code snippets. One of them produces timestamp(2) with time zone. Perfect! The other gives pg_catalog.timestamp(2), and that’s depressing. I’d like the second case to output either timestamp(2) with time zone or just timestamp(2), but not what it does now.

import { parse, deparse } from 'pgsql-parser'; // 17.7.8

const parsed = await parse(`
  CREATE TABLE public."ACTIVITY" (
    "ACTIVITY_ID" bigint NOT NULL,
    "PUBLISHED" timestamp(2) with time zone
  )
`);

const desparsed = await deparse(parsed);

console.log(desparsed);
// CREATE TABLE public."ACTIVITY" ("ACTIVITY_ID" bigint NOT NULL, "PUBLISHED" timestamp(2) with time zone)

import { parse, deparse } from 'pgsql-parser'; // 17.7.8

const parsed = await parse(`
  CREATE TABLE public."ACTIVITY" (
    "ACTIVITY_ID" bigint NOT NULL,
    "PUBLISHED" timestamp(2)
  )
`);

const desparsed = await deparse(parsed);

console.log(desparsed);
// CREATE TABLE public."ACTIVITY" ("ACTIVITY_ID" bigint NOT NULL, "PUBLISHED" pg_catalog.timestamp(2))

Can’t figure out why the code is written this way. And where are timestamp and time?

PLAYGROUND

The same goes for the pg_catalog.text :-(

[pyramation]

Thanks for the detailed issue :) working on it!

Can you share an example for text? I cannot reproduce that one.

FYI — pg_catalog being added doesn't break anything, the AST is equal, which is why it's there. I'll still work to remove it though. This is seemingly functional code (based on a quick test), so I wanted to make sure you're not concerned from that standpoint. I agree with your preference.

P.S. also — should I default pretty printing on? (newlines, tabs?) not sure if you found that option in the new version

[pyramation]

here are the new snapshots

exports[`pretty: misc/pg_catalog-timestamp-etc-1.sql 1`] = `
"CREATE TABLE public."ACTIVITY" (
  "ACTIVITY_ID" bigint NOT NULL,
  "PUBLISHED" timestamp(2) with time zone
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-2.sql 1`] = `
"CREATE TABLE public."ACTIVITY" (
  "ACTIVITY_ID" bigint NOT NULL,
  "PUBLISHED" timestamp(2)
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-3.sql 1`] = `
"CREATE TABLE public."EXAMPLE" (
  "MESSAGE" text
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-4.sql 1`] = `
"CREATE TABLE public."EXAMPLE_TIME" (
  "START_TIME" time
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-5.sql 1`] = `
"CREATE TABLE public."EXAMPLE_TIMETZ" (
  "START_TIME" time with time zone
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-6.sql 1`] = `
"CREATE TABLE public."EXAMPLE_TIME_PRECISION" (
  "START_TIME" time(3)
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-7.sql 1`] = `
"CREATE TABLE public."EXAMPLE_TIMETZ_PRECISION" (
  "START_TIME" time(3) with time zone
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-8.sql 1`] = `
"CREATE TABLE public."EXAMPLE_TIMESTAMP" (
  "CREATED_AT" timestamp
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-9.sql 1`] = `
"CREATE TABLE public."EXAMPLE_TIMESTAMPTZ" (
  "CREATED_AT" timestamp with time zone
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-10.sql 1`] = `
"CREATE TABLE public."EXAMPLE_INTERVAL" (
  "DURATION" interval
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-11.sql 1`] = `
"CREATE TABLE public."EXAMPLE_INTERVAL_PRECISION" (
  "DURATION" interval(2)
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-12.sql 1`] = `
"CREATE TABLE public."EXAMPLE_DATE" (
  "BIRTHDAY" date
)"
`;

exports[`pretty: misc/pg_catalog-timestamp-etc-13.sql 1`] = `
"CREATE TABLE public."EXAMPLE_BOOL" (
  "IS_ACTIVE" boolean
)"
`;

[pyramation]

Successfully published:
 - pgsql-deparser@17.9.1
 - pgsql-parser@17.7.9
 - @pgsql/cli@1.31.9
 - @pgsql/transform@17.8.1
 - @pgsql/utils@17.7.8