Skip to content

Failling actions do not return an error code #17

@davidferlay

Description

@davidferlay

To reproduce

  • Consider this action, where a shell script is executed and contains exit 1 command:
    test.tar.gz

Observed

  • echo $? executed right action the action returns 0
  • The failling script does not pass it's return code to the action, so the action does not return the proper error code
➜ launchrctl platform:test        
Image "test:latest" doesn't exist locally, building...
...
Successfully built 0a8a7f65233b
Successfully tagged test:latest
+ pwd
/host
+ exit 1

➜ echo $?                                                                                                    
0

Expected

  • echo $? should return 1
  • The failling script should pass it's return code to the action so that it can return the proper return code, whether it's successful or error

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions