Skip to content

Avoid recursive discovery of actions in launchrctl --version #35

@davidferlay

Description

@davidferlay

Observed

  • Currently, recursive discovery of actions (**/actions/*/action.yaml) happens everytime a launchrctl command is executed
  • Considering that launchrctl binary may be installed globaly on system, user can execute it from any directory, including system root /
  • When that happens, command may take a lot of time to complete because of discovery time, which can be very long if disks are not SSD
  • That's by design and actually makes sense for most commands
  • However command --version does not need to discover actions, and can legitimately be run by user anywhere on it's system
  • https://github.com/launchrctl/launchr/blob/main/plugins/yamldiscovery/plugin.go#L49
  • https://github.com/launchrctl/launchr/blob/main/app.go#L220

Expected

  • --version command should not do any discovery

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions