Draft: Flow update #119
Merged
Draft: Flow update #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iberdinsky-skilld
force-pushed
the
flow-update
branch
4 times, most recently
from
09410f5 to
2615f4d
Compare
iberdinsky-skilld
force-pushed
the
flow-update
branch
from
2615f4d to
8dc78c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current flow implementation, we have a lot of custom calculations for each action, each padding and each folder
and they happen every render, which is
In this PR, I suggest using
https://github.com/dagrejs/dagre
For autolayout as shown in https://reactflow.dev/learn/layouting/layouting
And also lay out only top-level nodes in the layout, and lay out child nodes inside the parent using regular CSS and HTML
I also removed the customization of nodes and actions, since this can be done through regular MUI and ReactFlow elements.
The following problems should be solved in this PR:
#103
#111