Skip to content

Refactor to new actions.#98

Merged
lexbritvin merged 3 commits intomainfrom
new-action
Jan 16, 2025
Merged

Refactor to new actions.#98
lexbritvin merged 3 commits intomainfrom
new-action

Conversation

@lexbritvin
Copy link
Copy Markdown
Contributor

No description provided.

@iberdinsky-skilld
Copy link
Copy Markdown
Contributor

Having error on submit actions

2025/01/02 15:10:57 http: panic serving [::1]:54297: action data is not available, call "EnsureLoaded" method first to load the data
goroutine 37 [running]:
net/http.(*conn).serve.func1()
        net/http/server.go:1947 +0xbe
panic({0x63bef40?, 0x64e84a0?})
        runtime/panic.go:785 +0x132
github.com/launchrctl/launchr/pkg/action.(*Action).assertLoaded(...)
        github.com/launchrctl/launchr@v0.16.5-0.20241222204415-24d5b3d7ff0c/pkg/action/action.go:154
github.com/launchrctl/launchr/pkg/action.(*Action).ActionDef(...)
        github.com/launchrctl/launchr@v0.16.5-0.20241222204415-24d5b3d7ff0c/pkg/action/action.go:160
github.com/launchrctl/launchr/pkg/action.NewInput(0xc000039230?, 0x16?, 0xc0001a4180?, {0x64f12c0?, 0xc0004be3c0?})
        github.com/launchrctl/launchr@v0.16.5-0.20241222204415-24d5b3d7ff0c/pkg/action/action.input.go:40 +0x305
github.com/launchrctl/web/server.(*launchrServer).RunAction(0xc00060fb60, {0x64f10b0, 0xc0002b21c0}, 0xc0002a4500, {0xc000516162, 0xb})
        github.com/launchrctl/web/server/api.go:234 +0x294
github.com/launchrctl/web/server.(*ServerInterfaceWrapper).RunAction.func1({0x64f10b0?, 0xc0002b21c0?}, 0xc000516101?)
        github.com/launchrctl/web/server/openapi.gen.go:263 +0x43
net/http.HandlerFunc.ServeHTTP(0x2?, {0x64f10b0?, 0xc0002b21c0?}, 0x6?)
        net/http/server.go:2220 +0x29
github.com/launchrctl/web/server.(*ServerInterfaceWrapper).RunAction(0xc0004082a0, {0x64f10b0, 0xc0002b21c0}, 0xc0002a4500)
        github.com/launchrctl/web/server/openapi.gen.go:270 +0x1fa
net/http.HandlerFunc.ServeHTTP(0xc000516162?, {0x64f10b0?, 0xc0002b21c0?}, 0xc000670700?)
        net/http/server.go:2220 +0x29
github.com/go-chi/chi/v5.(*ChainHandler).ServeHTTP(0xc0006361e0?, {0x64f10b0?, 0xc0002b21c0?}, 0xc000516155?)
        github.com/go-chi/chi/v5@v5.2.0/chain.go:31 +0x26
github.com/go-chi/chi/v5.(*Mux).routeHTTP(0xc00060fb00, {0x64f10b0, 0xc0002b21c0}, 0xc0002a4500)
        github.com/go-chi/chi/v5@v5.2.0/mux.go:480 +0x2e2
net/http.HandlerFunc.ServeHTTP(0xc000195720?, {0x64f10b0?, 0xc0002b21c0?}, 0xc0002a4500?)
        net/http/server.go:2220 +0x29
github.com/go-chi/cors.(*Cors).Handler-fm.(*Cors).Handler.func1({0x64f10b0, 0xc0002b21c0}, 0xc0002a4500)
        github.com/go-chi/cors@v1.2.1/cors.go:228 +0x17e
net/http.HandlerFunc.ServeHTTP(0x64f2e30?, {0x64f10b0?, 0xc0002b21c0?}, 0x69ed700?)
        net/http/server.go:2220 +0x29
github.com/go-chi/chi/v5.(*Mux).ServeHTTP(0xc00060fb00, {0x64f10b0, 0xc0002b21c0}, 0xc0002a43c0)
        github.com/go-chi/chi/v5@v5.2.0/mux.go:90 +0x2ee
net/http.serverHandler.ServeHTTP({0x64ee8d8?}, {0x64f10b0?, 0xc0002b21c0?}, 0x6?)
        net/http/server.go:3210 +0x8e
net/http.(*conn).serve(0xc0000e43f0, {0x64f2df8, 0xc00047e9c0})
        net/http/server.go:2092 +0x5d0
created by net/http.(*Server).Serve in goroutine 1
        net/http/server.go:3360 +0x485

@davidferlay
Copy link
Copy Markdown
Contributor

As discussed with @iberdinsky-skilld on chat: http://localhost:8080/actions is ok but http://localhost:8080/flow is broken (white page)

@iberdinsky-skilld
Copy link
Copy Markdown
Contributor

Fixed UI and submit.

@davidferlay
Copy link
Copy Markdown
Contributor

davidferlay commented Jan 15, 2025

Does not look ok:

image

image

Can be reproduced with:

plasmactl build --no-cache -t 500s --tag nethttpomithttp2 -vvv \
-p github.com/launchrctl/compose@new-action \
-p github.com/launchrctl/keyring@new-action \
-p github.com/launchrctl/launchr@new-action \
-p github.com/launchrctl/web@new-action \
-p github.com/skilld-labs/plasmactl-bump/v2@new-action \
-p github.com/skilld-labs/plasmactl-dependencies@new-action \
-p github.com/skilld-labs/plasmactl-meta@new-action \
-p github.com/skilld-labs/plasmactl-package@new-action \
-p github.com/skilld-labs/plasmactl-publish@new-action \
-p github.com/skilld-labs/plasmactl-update@new-action \
-n plasmactl -o plasmactl --build-version v0.0.0

@lexbritvin lexbritvin merged commit 907a30b into main Jan 16, 2025
@lexbritvin lexbritvin deleted the new-action branch May 30, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants