Skip to content

Conversation

@personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jun 11, 2025

Summary

This pull request retries opening the go-to-anything dialog on failure. This should make a CI failure less likely.

Notes

  • Interestingly, based on the log output, the go-to-anything dialog was failing to open the third time through this loop, the second time through the loop (on test retry), and the third time through the loop again:

    for (let i = 0; i < 3; i++) {
    await goToAnything.open(electronApp);

@personalizedrefrigerator personalizedrefrigerator changed the title Chore: CI: Re-try opening the go-to-anything dialog on failure Chore: CI: Retry opening the go-to-anything dialog on failure Jun 11, 2025
@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms ci Related to Joplin's automated update/build (continuous integration) labels Jun 11, 2025
@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Jun 11, 2025

I'm re-running CI after an unrelated test failure:

[joplin]: FAIL tests/services/plugins/PluginService.js
[joplin]:   ● services_PluginService › should create the data directory
[joplin]: 
[joplin]:     TypeError: Cannot read properties of undefined (reading 'title')
[joplin]: 
[joplin]:       367 |
[joplin]:       368 | 		const folders = await Folder.all();
[joplin]:     > 369 | 		expect(JSON.parse(folders[0].title)).toBe(expectedPath);
[joplin]:           | 		                             ^
[joplin]:       370 | 	}));
[joplin]:       371 |
[joplin]:       372 | 	it('should uninstall multiple plugins', async () => {
[joplin]: 
[joplin]:       at Object.title (tests/services/plugins/PluginService.ts:369:32)

The failure occurred here:

expect(JSON.parse(folders[0].title)).toBe(expectedPath);

@laurent22 laurent22 merged commit 364b249 into laurent22:dev Jun 12, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to Joplin's automated update/build (continuous integration) desktop All desktop platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants