Skip to content

Add modern cmake support#249

Merged
lava merged 1 commit into
lava:masterfrom
fferflo:add-cmake
Mar 25, 2021
Merged

Add modern cmake support#249
lava merged 1 commit into
lava:masterfrom
fferflo:add-cmake

Conversation

@fferflo
Copy link
Copy Markdown
Contributor

@fferflo fferflo commented Feb 10, 2021

Adds cmake support without modifications to the rest of the library. This includes an install target which enables including this library from another cmake project with:

find_package(matplotlib_cpp REQUIRED)
target_link_library(YOURTARGET PUBLIC matplotlib_cpp::matplotlib_cpp)

@lava
Copy link
Copy Markdown
Owner

lava commented Mar 25, 2021

Hi, thanks for contributing!

As the formerly very simple Makefile has grown more and more complicated (and as I've become much more acquainted with the inner workings of cmake) I think my rationale for not merging #55 has no merit anymore.

@lava lava merged commit 08ff087 into lava:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants