Implement STL-like interface for plotting generic data structures #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is motivated by the desire to plot data in generic data structures without the boilerplate of copying data into
std::vectorsbefore each plot. (I just had to plot a 101385-element Eigen::VectorXd and the copy was NOT fun).The solution adopted is to follow the example of the STL and define the graph data by a pair of templated input iterators. For ease of use, the interface is designed to mimic the STL in the following manner.
only 2D lineplots and scatter plots are addressed for the time being.
In due diligence, the examples
stl_containers.cppandeigen_objects.cppand a section reviewing this interface in the README are added.I think the main sticking points regarding this PR are
I suppose C++20
<ranges>is the silver bullet to resolve point 1, and C++20contiguous_iteratorconcept deals with point 2, but this is the most elegant solution I have for now. If there's anything I can to do better before this PR can be merged, let me know!