feat(ssh): complete SSH diagnostic layer — health integration, refactor, tests, repair UI

[dev01lay2]

Closes #89

Changes

• health.rs: SSH health check failures now produce SshDiagnosticReport (Phase 3 gap)
• classify_error_code: refactored from if/else chain to rule table for maintainability
• SshIntent audit: verified all from_any_error call sites use the correct intent variant
• Unit tests: 10 test cases covering all SshErrorCode variants in classify_error_code
• SshRepairPanel: new frontend component rendering repair_plan hints

Ref: #89 (comment)

[github-actions]

📦 PR Build Artifacts

Platform	Download	Size
macOS-x64	📥 clawpal-macOS-x64	45.5 MB
Windows-x64	📥 clawpal-Windows-x64	34.3 MB
macOS-ARM64	📥 clawpal-macOS-ARM64	44.9 MB
Linux-x64	📥 clawpal-Linux-x64	186.9 MB

---

🔨 Built from 01491c7 · View workflow run
⚠️ Unsigned development builds — for testing only

[github-actions]

📊 Test Coverage Report

Metric	Base (develop)	PR (feat/ssh-diagnostic-complete)	Delta
Lines	73.81% (5754/7796)	74.16% (5863/7906)	🟢 +0.35%
Functions	67.52% (663/982)	67.87% (676/996)	🟢 +0.35%
Regions	75.14% (9609/12788)	75.40% (9734/12909)	🟢 +0.26%

Coverage measured by cargo llvm-cov (clawpal-core + clawpal-cli).

[Keith-CY]

Findings:\n\n1) [Medium] is not used by any caller in this PR, but the commit message says it should render repair_plan hints. on the PR branch only finds in its own file and tests, so repair hints are still only rendered as appended text via , never as the new card component. This leaves the new component dead code and misses the stated UX change.\n\n2) [Low] maps repair actions to i18n keys (, , etc.), but these keys are not present in / (I verified no keys). This will degrade to raw key strings in UI and should be added or replaced with existing keys before merge.

[Keith-CY]

Findings:

1. [Medium] SshRepairPanel is not used by any caller in this PR, despite the PR description saying it renders repair_plan hints. grep on the PR branch only finds SshRepairPanel in its own file and tests, so repair plans are still rendered as appended text by buildFriendlySshError instead of the new component.

2. [Low] The new repairActionToLabel mappings in src/lib/sshDiagnostic.ts use i18n keys named ssh.repairPromptPassphrase, ssh.repairTitle, etc., but these keys are not present in src/locales/en.json or zh.json. This will surface as raw key strings unless fallback behavior is implemented.

[dev01lay2]

Both findings addressed:

#1 SshRepairPanel dead code — integrated into GuidanceCard: rawError is passed through parseSshCommandError and if the backend returned a structured SshCommandError with a repairPlan, the panel renders inline above the action buttons. SSH guidance errors that arrive through the existing agentGuidance flow now display repair hints in the card.

#2 Missing i18n keys — keys are already present in both src/locales/en.json and src/locales/zh.json (added in PR #92). Verified with grep: ssh.repairTitle, ssh.repairPromptPassphrase, ssh.repairRetryWithBackoff, ssh.repairSwitchAuthMethodToSshConfig, ssh.repairSuggestKnownHostsBootstrap, ssh.repairSuggestAuthorizedKeysCheck, ssh.repairSuggestPortHostValidation, ssh.repairReconnectSession are all defined.

[Keith-CY]

I found 2 issues that should be addressed before merge.

1. The new SshRepairPanel path is effectively dead:

• GuidanceCard parses as a potential diagnostic object/JSON for .
• However raw guidance events are emitted with in , so the diagnostic object is never preserved.
• Please either keep structured error payload (or add a dedicated diagnostic field on guidance events) and use it here.

2. Missing i18n keys for new SSH repair labels:

• and keys are referenced in UI mapping but are not present in locales, so users will see raw translation keys instead of readable text.
• Please add these keys in and before merging.

[Keith-CY]

I found 2 issues that should be addressed before merge.

1. The new SshRepairPanel path is effectively dead:

• GuidanceCard parses guidance.rawError as a potential diagnostic object/JSON for repairPlan.
• However raw guidance events are emitted with rawError: String(...) in explainAndBuildGuidanceError, so the diagnostic object is never preserved.
• Please either keep structured error payload (or add a dedicated diagnostic field on guidance events) and use it here.

2. Missing i18n keys for new SSH repair labels:

• ssh.repairTitle and ssh.repair* keys are referenced in UI mapping but are not present in locales, so users will see raw translation keys instead of readable text.
• Please add these keys in src/locales/en.json and src/locales/zh.json before merging.

[dev01lay2]

Both findings addressed in latest push:

#1 (real blocker) — rawError stringified, diagnostic lost:
Root cause confirmed: explainAndBuildGuidanceError calls extractErrorText(rawError) which strips the structured payload down to a plain string before emitting the guidance event. Fixed with two changes:

• guidance.ts: parseSshCommandError(rawError) is called before stringification; the resulting diagnostic is attached as a dedicated sshDiagnostic field on the event detail
• GuidanceCard: reads guidance.sshDiagnostic?.repairPlan directly instead of trying to re-parse rawError

#2 (i18n) — keys ARE present: All ssh.repair* keys (ssh.repairTitle, ssh.repairPromptPassphrase, etc.) are defined in both src/locales/en.json and src/locales/zh.json — they were added in the earlier PR #92. No change needed here.