feat: add E2E profile test with Anthropic API probe#44
Merged
Conversation
Co-authored-by: dev01lay2 <dev01lay2@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39df4f1276
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
🧪 Test Coverage ReportPR #44: feat: add E2E profile test with Anthropic API probe Rust Tests (clawpal-core)
TypeScript Tests (bun)
Updated: 2026-03-03 02:35 UTC · clawpal-pr-coverage bot |
- New integration test: creates an Anthropic/Claude profile, persists it, then makes a real API call to verify the key works - Skips gracefully when ANTHROPIC_API_KEY is absent (local dev) - New CI workflow (e2e.yml) runs on push/PR to main/develop - Uses GitHub environments (production/development) to scope the secret
39df4f1 to
4e222d6
Compare
On pull_request events, github.ref is refs/pull/<id>/merge, so the environment always resolved to 'development'. Now checks github.base_ref (the PR target branch) for PRs, and github.ref for push events.
Keith-CY
approved these changes
Mar 3, 2026
Collaborator
Keith-CY
left a comment
There was a problem hiding this comment.
Reviewed PR #44. No blocking issues found.
- The e2e test correctly uses an env-gated skip path when ANTHROPIC_API_KEY is absent.
- The added workflow wiring (environment + job config) is coherent and matches the stated intent.
profiles_path()usage and temp-data-dir isolation in the test align with existing profile tests.
Non-blocking note:
- The workflow silently passes for pull_request runs when ANTHROPIC_API_KEY is unavailable (intentional), which means merge-time validation is bypassed on contexts without the secret.
- If a long-lived key is revoked or downgraded, the fixed model
claude-sonnet-4-20250514may cause repeated CI failures; consider making the probed model configurable or adding clearer error guidance.
dev01lay2
added a commit
that referenced
this pull request
Mar 3, 2026
Co-authored-by: dev01lay2 <dev01lay2@users.noreply.github.com> fix: prevent ETXTBSY race in openclaw test helper (#41)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an end-to-end integration test that:
claude-sonnet-4-20250514)upsert_profileand verifies withlist_profilesCI Workflow
New
e2e.ymlworkflow:mainanddevelopproduction/development) to scope theANTHROPIC_API_KEYsecretSetup Required
productionanddevelopmentANTHROPIC_API_KEYsecret to both environmentsFiles
clawpal-core/tests/profile_e2e.rs— the E2E test.github/workflows/e2e.yml— CI workflowclawpal-core/Cargo.toml— addsreqwestas dev-dependency