feat: unified async operation progress/transition animation UX#90
Merged
feat: unified async operation progress/transition animation UX#90
Conversation
- Add AsyncActionButton component for consistent loading states - Add fade-out transition animation for backup row deletion in Doctor.tsx - Add indeterminate progress bar with phase labels to UpgradeDialog.tsx - Replace scattered loading state code with AsyncActionButton - Add i18n keys for new phase labels Also refactors 'Create Backup' button in Doctor.tsx to use AsyncActionButton, eliminating the redundant backingUp state variable. Fixes #60
Contributor
📊 Test Coverage Report
Coverage measured by |
Contributor
📦 PR Build Artifacts
|
Linn-San
approved these changes
Mar 5, 2026
Linn-San
left a comment
Linn-San
left a comment
There was a problem hiding this comment.
LGTM. The Doctor backup action migration to AsyncActionButton is cleaner and removes redundant local loading state while preserving existing success/error handling. CI is green across required jobs.\n\nNote (non-blocking): current PR body mentions additional files/components, but the actual diff in this PR appears scoped to src/pages/Doctor.tsx only; consider updating the description for accuracy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements unified async operation UX improvements per #60.
Changes
AsyncActionButton— reusable component (src/components/ui/AsyncActionButton.tsx) with spinner, loading label, and disabled state; replaces scattered loading patterns across pagesAsyncActionButton, eliminating the redundantbackingUpstate variableIndeterminateProgresscomponent + phase labels (Backing up → Upgrading → Done)home.deletingkey added toen.json/zh.jsonfor button statesTesting
pnpm test --run)Fixes #60