fix(ui): consolidate double glow effect in kanvas pop-up#1042
fix(ui): consolidate double glow effect in kanvas pop-up#1042Rudra2637 wants to merge 2 commits into
Conversation
Signed-off-by: Rudra2637 <singhrudra2637@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request simplifies the box-shadow styling in the corner popup SCSS file by reducing the blur radius and removing a shadow layer. A review comment suggests using the $primary variable instead of hardcoded RGB values to improve maintainability and consistency with the rest of the project.
| border: 1px solid #00d3a9; | ||
| border-radius: 5%; | ||
| box-shadow: 0 0 42px rgba(0, 211, 169, 0.85), 0 0 80px rgba(0, 211, 169, 0.25); | ||
| box-shadow: 0 0 28px rgba(0, 211, 169, 0.55); |
There was a problem hiding this comment.
To improve maintainability and ensure consistency with the rest of the project, consider using the $primary variable instead of the hardcoded RGB values. This ensures that if the brand color changes, the glow effect will update automatically. Note that $primary is already used in lines 149 and 159.
| box-shadow: 0 0 28px rgba(0, 211, 169, 0.55); | |
| box-shadow: 0 0 28px rgba($primary, 0.55); |
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1042/
|
| border: 1px solid #00d3a9; | ||
| border-radius: 5%; | ||
| box-shadow: 0 0 42px rgba(0, 211, 169, 0.85), 0 0 80px rgba(0, 211, 169, 0.25); | ||
| box-shadow: 0 0 28px rgba(0, 211, 169, 0.55); |
There was a problem hiding this comment.
take gemini's review into consideration and prolly use secondary over primary variable. scss supports this so makes it easier.
I tried it on my end and the results were almost identical for both primary and secondary, it comes down to you what you think suits better.
And even if there is a suggestion change by a member, you will just have to change the variable name there.
There was a problem hiding this comment.
Will go with your suggested change. On my end, I was trying to consolidate the border and background glow effect, which is why I used that approach.
Signed-off-by: Rudra2637 <singhrudra2637@gmail.com>
|
@Rajesh-Nagarajan-11 your opinion ? |
Description
This PR fixes the excessive bottom glow effect in the Kanvas popup by refining the
box-shadowstyling.Changes Made
Fixes #1035
Notes for Reviewers
Signed commits