Skip to content

fix(ui): consolidate double glow effect in kanvas pop-up#1042

Open
Rudra2637 wants to merge 2 commits into
layer5io:masterfrom
Rudra2637:fix/consolidate-popup-bottom-lines-clean
Open

fix(ui): consolidate double glow effect in kanvas pop-up#1042
Rudra2637 wants to merge 2 commits into
layer5io:masterfrom
Rudra2637:fix/consolidate-popup-bottom-lines-clean

Conversation

@Rudra2637
Copy link
Copy Markdown
Contributor

Description

This PR fixes the excessive bottom glow effect in the Kanvas popup by refining the box-shadow styling.

Changes Made

  • Reduced the intensity of the popup glow effect.
  • Consolidated the visual appearance of the bottom border/glow to create a cleaner UI.
  • Preserved the existing neon aesthetic while improving visual consistency.

Fixes #1035

Notes for Reviewers

  • The popup styling was adjusted only for visual refinement.
  • No functional changes were introduced.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rudra2637 <singhrudra2637@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the box-shadow styling in the corner popup SCSS file by reducing the blur radius and removing a shadow layer. A review comment suggests using the $primary variable instead of hardcoded RGB values to improve maintainability and consistency with the rest of the project.

Comment thread assets/scss/_kanvas-corner-popup.scss Outdated
border: 1px solid #00d3a9;
border-radius: 5%;
box-shadow: 0 0 42px rgba(0, 211, 169, 0.85), 0 0 80px rgba(0, 211, 169, 0.25);
box-shadow: 0 0 28px rgba(0, 211, 169, 0.55);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure consistency with the rest of the project, consider using the $primary variable instead of the hardcoded RGB values. This ensures that if the brand color changes, the glow effect will update automatically. Note that $primary is already used in lines 149 and 159.

Suggested change
box-shadow: 0 0 28px rgba(0, 211, 169, 0.55);
box-shadow: 0 0 28px rgba($primary, 0.55);

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1042/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Comment thread assets/scss/_kanvas-corner-popup.scss Outdated
border: 1px solid #00d3a9;
border-radius: 5%;
box-shadow: 0 0 42px rgba(0, 211, 169, 0.85), 0 0 80px rgba(0, 211, 169, 0.25);
box-shadow: 0 0 28px rgba(0, 211, 169, 0.55);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take gemini's review into consideration and prolly use secondary over primary variable. scss supports this so makes it easier.

I tried it on my end and the results were almost identical for both primary and secondary, it comes down to you what you think suits better.
And even if there is a suggestion change by a member, you will just have to change the variable name there.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go with your suggested change. On my end, I was trying to consolidate the border and background glow effect, which is why I used that approach.

Signed-off-by: Rudra2637 <singhrudra2637@gmail.com>
@Rudra2637
Copy link
Copy Markdown
Contributor Author

@Rajesh-Nagarajan-11 your opinion ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Consolidate the bottom to lines in the site's pop-up

2 participants