Skip to content

[Docs] Default Permissions: add spacing between permission tables#1091

Open
PARTH-TUSSLE wants to merge 2 commits into
layer5io:masterfrom
PARTH-TUSSLE:docs/default-permissions-spacing-1075
Open

[Docs] Default Permissions: add spacing between permission tables#1091
PARTH-TUSSLE wants to merge 2 commits into
layer5io:masterfrom
PARTH-TUSSLE:docs/default-permissions-spacing-1075

Conversation

@PARTH-TUSSLE

@PARTH-TUSSLE PARTH-TUSSLE commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

Added vertical spacing between permission tables on the Default Permissions page to improve readability.

Preview of the fix :-
image

image

This PR fixes #1075

Signed commits

  • [✅] Yes, I signed my commits.

Signed-off-by: PARTH-TUSSLE <parthgartan26feb@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds margin styles for h2 elements following a .csvtable in assets/scss/_content_project.scss. The reviewer suggested using .td-initial + h2 instead of .csvtable + h2 to maintain consistency with the existing stylesheet.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread assets/scss/_content_project.scss Outdated
Comment on lines +217 to +220
.csvtable + h2 {
margin-top: 3rem;
margin-bottom: 1rem;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the existing stylesheet which uses the .td-initial class for styling these tables, consider using .td-initial + h2 instead of .csvtable + h2. This avoids relying on the specific .csvtable class in the global stylesheet and keeps the class usage unified.

Suggested change
.csvtable + h2 {
margin-top: 3rem;
margin-bottom: 1rem;
}
.td-initial + h2 {
margin-top: 3rem;
margin-bottom: 1rem;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PARTH-TUSSLE Please review the Gemini suggestions and verify whether they're correct. If they are, please apply the changes; otherwise, reject them with the appropriate reason.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishiraj38 , I've made the suitable changes according to Gemini suggestions.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1091/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@PARTH-TUSSLE Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Signed-off-by: PARTH-TUSSLE <parthgartan26feb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Default Permissions: The tables could use some spacing

3 participants