Add documentation of create model from kanvas #478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
amitamrutiya
added
pr/do-not-merge
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
There was a problem hiding this comment.
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
content/en/kanvas/concepts/relationships/index.md:53
- Typo in the word 'inheritence' — it should be 'inheritance'.
Hierarchical relationships involve either an ancestral connection of the components (i.e. the creation/deletion of a component higher up affects the existence of the components below in the lineage) or a connection which involves the inheritence of features from one component to the other.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Amit Amrutiya <amitamrutiya2210@gmail.com>
Comment on lines
87
to
88
| <img src="./model-fianlize.png" alt="model finalize step" width="600" style="margin-bottom: 25px;"> | ||
|
|
There was a problem hiding this comment.
The image filename 'model-fianlize.png' appears to be a typo. Consider renaming it to 'model-finalize.png' for consistency.
Suggested change
| <img src="./model-fianlize.png" alt="model finalize step" width="600" style="margin-bottom: 25px;"> | |
| <img src="./model-finalize.png" alt="model finalize step" width="600" style="margin-bottom: 25px;"> |
Comment on lines
+115
to
+116
| 4. New generated model will be appear in either shape or component picker. | ||
|
|
There was a problem hiding this comment.
[nitpick] The phrase 'New generated model will be appear' is grammatically incorrect. Consider rephrasing it to 'The generated model will appear in either the shape or component picker.'
Suggested change
| 4. New generated model will be appear in either shape or component picker. | |
| 4. The generated model will appear in either the shape or component picker. |
Signed-off-by: amitamrutiya <amitamrutiya2210@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
https://deploy-preview-478--bejewelled-pegasus-b0ce81.netlify.app/kanvas/concepts/create-model/
Signed commits