Skip to content

Conversation

@leulad
Copy link
Member

@leulad leulad commented May 12, 2025

Notes for Reviewers

This PR fixes #
add resources dropdown in nav menu #518

Signed commits

  • Yes, I signed my commits.

Know Issues:

  • Existing dropdown implementation has this issues
    1. multiple drop downs active at the same time
    2. pre defined property I was not able to locate which breaks nav when not using dropdown-menu class specifically. By which it forced me to alter existing products dropdown
resources-products-active

Signed-off-by: leulad <leuladnew@gmail.com>
@netlify
Copy link

netlify bot commented May 12, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit da584a5
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/6824eb33f338aa000842ce2c
😎 Deploy Preview https://deploy-preview-555--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We don't want to away from the grid layout in the app switcher menu, @leulad. Will you revert changes to that menu?

@leulad
Copy link
Member Author

leulad commented May 15, 2025

Most definetly, I will revert and push a new pr by tommorow!

@leecalcote
Copy link
Member

Most definetly, I will revert and push a new pr by tommorow!

Thank you

@leulad leulad closed this May 16, 2025
@leulad leulad deleted the nav-resources-drop branch May 16, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants