fix(navbar): prevent undefined cloud profile URLs

[miacycle]

Summary

• guard against missing Cloud profile avatar URLs in the docs navbar
• fall back to the Cloud home page when the authenticated profile payload has no user ID
• stop authenticated visitors from triggering requests to /cloud/undefined

Related Issue

Fixes #961

[Copilot]

Pull request overview

This PR updates the docs site navbar’s Cloud-authenticated user UI to avoid generating invalid/relative URLs (notably /cloud/undefined) when the profile payload is missing expected fields.

Changes:

• Adds a cloudAppUrl constant and uses it to build the Cloud profile API request URL.
• Introduces helpers to safely derive avatar_url and the user profile link, with fallbacks when missing.
• Updates the authenticated navbar UI to avoid setting a background image when no avatar URL is present, and to fall back to the Cloud home page when no user ID is available.

[github-actions]

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-962/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

[gemini-code-assist]

Code Review

This pull request refactors the navbar's user profile logic by centralizing the base URL and introducing helper functions for avatar and profile URL generation. The review feedback suggests further improvements, including using Hugo variables for the base URL to reduce duplication, adopting optional chaining for more idiomatic JavaScript, and adding safety checks for DOM elements to prevent potential runtime errors.

[gemini-code-assist]

The URL https://cloud.layer5.io is hardcoded in multiple places within this file (lines 189, 192, and 263). Since this is a Hugo template, it is recommended to define this URL as a single variable (e.g., using a Hugo variable or a Site parameter) to ensure consistency and simplify future updates.

[miacycle]

Consolidated the Cloud base URL into shared Hugo variables in this partial so the sign-in, profile, and academy links all derive from one source.

[gemini-code-assist]

This condition is quite verbose. Using optional chaining and a truthiness check is more idiomatic in modern JavaScript and effectively covers null, undefined, and empty strings for the id field.

Suggested change

	if (response && response.id !== undefined && response.id !== null && response.id !== "") {
	return `${cloudAppUrl}/user/${encodeURIComponent(response.id)}`;
	}
	const userId = response?.id;
	if (userId) {
	return cloudAppUrl + "/user/" + encodeURIComponent(userId);
	}

[miacycle]

Updated the helper to use an idiomatic optional-chaining check for the user ID before building the profile URL.

[gemini-code-assist]

It is safer to verify that avatarContainer exists before attempting to modify its style properties. If the element is missing from the DOM, this script will throw a TypeError, which could prevent subsequent logic (like setting isUserAuthenticated) from executing.

Suggested change

	const avatarContainer = document.querySelector('.avatar-container');
	avatarContainer.style.backgroundImage = avatarUrl ? `url("${avatarUrl}")` : "none";
	avatarContainer.style.backgroundSize = avatarUrl ? "cover" : "";
	const avatarContainer = document.querySelector('.avatar-container');
	if (avatarContainer) {
	avatarContainer.style.backgroundImage = avatarUrl ? "url(\"" + avatarUrl + "\")" : "none";
	avatarContainer.style.backgroundSize = avatarUrl ? "cover" : "";
	}

[miacycle]

Added a guard around the avatar container before setting its styles so the auth UI does not throw if that element is absent.