Skip to content

navbar fixed#6356

Closed
Dungeon-Masterji wants to merge 2 commits intolayer5io:masterfrom
Dungeon-Masterji:Navbar
Closed

navbar fixed#6356
Dungeon-Masterji wants to merge 2 commits intolayer5io:masterfrom
Dungeon-Masterji:Navbar

Conversation

@Dungeon-Masterji
Copy link
Contributor

Description
This PR fixes the navbar positioning issue. Previously, the navbar was set to sticky, which initially seemed to work but later failed on localhost. This fix ensures that the navbar remains in its fixed position consistently.

This PR fixes #6328

Notes for Reviewers

  • The issue was reproducible on localhost, where sticky was not functioning as expected.

  • The new implementation ensures the navbar stays in place across different environments.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Aditya Raj <adityaraj20112005@gmail.com>
@l5io
Copy link
Contributor

l5io commented Mar 30, 2025

🚀 Preview for commit 66dde0e at: https://67e971cdc3c77d1a33023d20--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 31, 2025

🚀 Preview for commit 03d3c88 at: https://67ea60953c3862fda75d0d90--layer5.netlify.app

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dungeon-Masterji
since fixed position does not occupy any space unlike sticky position, you can see the next section that is banner section is going behind the navbar.

  • To create spacing as is currently, we can use ::before
    Screen Shot 2025-03-31 at 15 02 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Navbar Should Be Sticky, But It's Not Working Again

3 participants