Fix default checkbox appearing#6359
Merged
vishalvivekm merged 1 commit intolayer5io:masterfrom Apr 1, 2025
Souradip121:checkboxfix
Merged
Fix default checkbox appearing#6359vishalvivekm merged 1 commit intolayer5io:masterfrom Souradip121:checkboxfix
vishalvivekm merged 1 commit intolayer5io:masterfrom
Souradip121:checkboxfix
Conversation
Member
|
🚀 Preview for commit 2afa407 at: https://67ebb5ba260534105da81ef4--layer5.netlify.app |
Contributor
|
Excellent @Souradip121. We'd previously discussed in sites meeting whether removing the |
Signed-off-by: Souradip Pal <souradip1000@gmail.com>
Contributor
|
Please make sure to sign off your commit, following: https://github.com/layer5io/layer5/pull/6359/checks?check_run_id=39759298618 |
vishalvivekm
approved these changes
Apr 1, 2025
Contributor
vishalvivekm
left a comment
There was a problem hiding this comment.
LGTM. Thanks much for your contributions @Souradip121
Member
|
@GARY121github @Radha2786 please be more careful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6351
Notes for Reviewers
After researching a bit, I found that #6317 was causing the issue, the code
was removed which essentially solved the #6309 issue, where the toggle button appeared but caused the default checkbox to appear as the checkbox was formed by
Here you can see the consequence of removing the lines from #6317 which essentially caused the default checkboxes to appear.
I fixed this by re adding the removed stylling code from #6317 and also making sure the toggle button also appears by adding exceptions to the dark light switcher toggle button
Signed commits