Skip to content

Fix default checkbox appearing#6359

Merged
vishalvivekm merged 1 commit intolayer5io:masterfrom
Souradip121:checkboxfix
Apr 1, 2025
Merged

Fix default checkbox appearing#6359
vishalvivekm merged 1 commit intolayer5io:masterfrom
Souradip121:checkboxfix

Conversation

@Souradip121
Copy link
Copy Markdown
Contributor

@Souradip121 Souradip121 commented Apr 1, 2025

Description

This PR fixes #6351

Notes for Reviewers
After researching a bit, I found that #6317 was causing the issue, the code

input[type=checkbox] {
      display: none;
    }

was removed which essentially solved the #6309 issue, where the toggle button appeared but caused the default checkbox to appear as the checkbox was formed by

<input type="checkbox" name="CM-checklist-1" id="CM-checklist-1" />
            <label htmlFor="CM-checklist-1">
              Prior technical community management experience
            </label>

Here you can see the consequence of removing the lines from #6317 which essentially caused the default checkboxes to appear.

I fixed this by re adding the removed stylling code from #6317 and also making sure the toggle button also appears by adding exceptions to the dark light switcher toggle button

image

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Copy Markdown
Member

l5io commented Apr 1, 2025

🚀 Preview for commit 2afa407 at: https://67ebb5ba260534105da81ef4--layer5.netlify.app

@vishalvivekm
Copy link
Copy Markdown
Contributor

Excellent @Souradip121.

We'd previously discussed in sites meeting whether removing the display: none will cause any undesirable effect: https://youtu.be/hRuMwxhBPE0?t=2753

Signed-off-by: Souradip Pal <souradip1000@gmail.com>
@vishalvivekm
Copy link
Copy Markdown
Contributor

Please make sure to sign off your commit, following: https://github.com/layer5io/layer5/pull/6359/checks?check_run_id=39759298618

Copy link
Copy Markdown
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks much for your contributions @Souradip121

@leecalcote
Copy link
Copy Markdown
Member

@GARY121github @Radha2786 please be more careful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unintended Empty Checklist Items on Community Manager Checklist Page

4 participants