site-config: adding a new plugin to remove unused CSS at build time.#6945
site-config: adding a new plugin to remove unused CSS at build time.#6945ritesh-karankal merged 6 commits intolayer5io:masterfrom
Conversation
Rajesh-Nagarajan-11
left a comment
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
Build failed kindly check out that and fix ASAP
|
@Rajesh-Nagarajan-11, build is failing due to some deep underlying issue regarding html static file builds caused by Css that is being removed by the plugin, I am looking into it, but it might require a bit more time than usual, I will try to fix it ASAP!! |
amishhaa
force-pushed
the
plugin
branch
2 times, most recently
from
b0d4e02 to
45a93ae
Compare
|
DCO |
|
🚀 Preview for commit a05433b at: https://68dc17e588b8c3653fbd52b2--layer5.netlify.app |
|
Enlist is not failing due to my changes, this PR LGTM, I'll look into fixing this Enlist failure soon. cc: @Rajesh-Nagarajan-11 |
|
If eslint failure not related to your changes means no need leave it , create a new pr for eslint fix |
|
@Rajesh-Nagarajan-11 sure! |
|
Sync your branch to recent commits |
|
@Rajesh-Nagarajan-11 done! |
amishhaa
force-pushed
the
plugin
branch
6 times, most recently
from
3284487 to
f064464
Compare
Signed-off-by: amisha <amishhhaaaa@gmail.com>
|
🚀 Preview for commit 5cc9813 at: https://68de3fb634c47f62c7d3617d--layer5.netlify.app |
|
🚀 Preview for commit acc294b at: https://68dea5007a7b5f49213158cf--layer5.netlify.app |
|
🚀 Preview for commit e6ea923 at: https://68dfa0e83d69dae39b1dbadd--layer5.netlify.app |
|
🚀 Preview for commit 8f94a6b at: https://68dfdf5e7ae5ec8156997b66--layer5.netlify.app |
|
Hello, I have resolved conflicts a few times already, could we please review and merge this before it diverges again? Thank you. cc: @Rajesh-Nagarajan-11 @ritesh-karankal |
|
🚀 Preview for commit 7aaf49f at: https://68e0e404e7ed38b6a6dad04a--layer5.netlify.app |
Rajesh-Nagarajan-11
left a comment
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
LGTM @amishhaa Great work !!
|
🚀 Preview for commit 6c592a6 at: https://68e20dadb720257189b771db--layer5.netlify.app |
5 participants
Description
This PR is a part of #6930 minify css, #6929 reduce unused css, #6927 minify css.
Reducing unused CSS to speed up performance of our web pages.
#6924 minify css and reduce unused css.
Results after adding this plugin:
Notes for Reviewers
Adding this plugin was also the recommended approach by PageSpeed insights as highlighted by the screen shot above.
Signed commits