Skip to content

[CI] Upgrade to eslint v9#7120

Merged
Rajesh-Nagarajan-11 merged 4 commits intolayer5io:masterfrom
Siddhi-sahu:eslint-new-v9
Nov 12, 2025
Merged

[CI] Upgrade to eslint v9#7120
Rajesh-Nagarajan-11 merged 4 commits intolayer5io:masterfrom
Siddhi-sahu:eslint-new-v9

Conversation

@Siddhi-sahu
Copy link
Copy Markdown
Contributor

@Siddhi-sahu Siddhi-sahu commented Nov 11, 2025

Description

This PR fixes #6891

Notes for Reviewers

Initial migration using :

  1. npx @eslint/migrate-config .eslintrc.js
  2. npm install globals @eslint/js @eslint/eslintrc -D
  3. npm install eslint@latest -D

My Previous attempt on migrating eslint to v9, resulted in this error during the build:
Pasted Graphic 2

i resolved this issue by the following:

  1. npm install --save-dev gatsby-plugin-eslint eslint eslint-webpack-plugin eslint-config-react-app
  2. creating an empty .eslintrc.js file in the root dir (this prevents Gatsby internal eslint loader trying to use the deprecated options)

The sites builds normal now:
image
image

checks:
Pasted Graphic 3

No problem with Husky pre-commit hook inside the devcontainer:
Pasted Graphic 4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Siddhi sahu <himanisahu739@gmail.com>
@l5io
Copy link
Copy Markdown
Member

l5io commented Nov 11, 2025

🚀 Preview for commit e07ca5e at: https://6912c08f5ef5199b76af14d8--layer5.netlify.app

Signed-off-by: Siddhi sahu <himanisahu739@gmail.com>
@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

✖ 86 problems (78 errors, 8 warnings) in eslint

@l5io
Copy link
Copy Markdown
Member

l5io commented Nov 11, 2025

🚀 Preview for commit cf2f4fa at: https://6912c49f8ec7bf44bcf6f6d4--layer5.netlify.app

Comment thread .eslintrc.js
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you delete that ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .desktop-lighthouserc.js
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file you just fixed trailing spaces right ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, eslint did that.

Copy link
Copy Markdown
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good !! Thanks himani 🫶

Copy link
Copy Markdown
Member

@KatalKavya96 KatalKavya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@l5io
Copy link
Copy Markdown
Member

l5io commented Nov 12, 2025

🚀 Preview for commit 73a9e85 at: https://691497e5443f0e30daa723f6--layer5.netlify.app

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 merged commit 0e946fd into layer5io:master Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Upgrade to eslint v9

5 participants