fix: improve integration logo visibility in dark and light mode#7706
Open
AnkitRewar11 wants to merge 1 commit intolayer5io:masterfrom
Open
fix: improve integration logo visibility in dark and light mode#7706AnkitRewar11 wants to merge 1 commit intolayer5io:masterfrom
AnkitRewar11 wants to merge 1 commit intolayer5io:masterfrom
Conversation
Contributor
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7706/
|
- Fix darkModeIntegrationIcon reference in IntegrationsGrid.js - Fix Aerospike white SVG color from dark to white - Fix Solr SVG by removing invalid sodipodi tags - Fix Ngrok color SVG empty clipPath and update fill color - Fix Vald empty white SVG with proper white paths - Fix Rustrial AWS EKS empty SVG files with placeholder icons Signed-off-by: ankitrewar11 <ankitrewar11@gmail.com>
AnkitRewar11
force-pushed
the
fix/dark-mode-integration-logos
branch
from
1d3022a to
719f704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7676
This PR fixes integration logo visibility issues in both dark mode and light mode on the Meshery integrations page.
Changes Made
darkModeIntegrationIconreference that was pointing to color icon instead of white icon#1A1A1A(dark) instead of#FFFFFF(white), causing invisibility in dark modesodipodi:namedviewtags from both color and white SVGs that were causing rendering issues in dark modeclipPathin color SVG that was hiding the logo in light mode, and updated fill color to#006AFFNotes for Reviewers
Signed commits