Skip to content

feat(icons): add 7 missing material icons for meshery migration#1348

Merged
Rajesh-Nagarajan-11 merged 5 commits intolayer5io:masterfrom
ashwanisingh011:feat/add-missing-mui-icons
Mar 12, 2026
Merged

feat(icons): add 7 missing material icons for meshery migration#1348
Rajesh-Nagarajan-11 merged 5 commits intolayer5io:masterfrom
ashwanisingh011:feat/add-missing-mui-icons

Conversation

@ashwanisingh011
Copy link
Contributor

Description

This PR adds 7 missing Material UI SVG icons to the Sistent library.

These icons are required for the ongoing MUI-to-Sistent migration in the Meshery repository, specifically to support the mappings in ui/components/NameToIcon.tsx.

Icons added:

  • BuildRoundedIcon
  • DirectionsCarIcon
  • ExploreIcon
  • FileCopyIcon
  • ListAltIcon
  • SimCardIcon
  • SupervisedUserCircleIcon

Related Issue: Addresses meshery/meshery# meshery/meshery#17682

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ashwanisingh011 <ashwanisingh9737@gmail.com>
Signed-off-by: ashwanisingh011 <ashwanisingh9737@gmail.com>
@ashwanisingh011 ashwanisingh011 force-pushed the feat/add-missing-mui-icons branch from f4abcdd to 38be150 Compare February 28, 2026 18:11
@Bhumikagarggg
Copy link
Contributor

@ashwanisingh011 Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@Rajesh-Nagarajan-11
Copy link
Member

Rajesh-Nagarajan-11 commented Mar 2, 2026

Did you test these icons with the meshery ui ?

@ashwanisingh011 ashwanisingh011 force-pushed the feat/add-missing-mui-icons branch from 7c99d71 to 2f3de60 Compare March 2, 2026 16:37
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint errors please

… paths

Signed-off-by: ashwanisingh011 <ashwanisingh9737@gmail.com>
@leecalcote
Copy link
Member

@ashwanisingh011 have you used these new icons? Have you tested them?

@ashwanisingh011
Copy link
Contributor Author

Hi @leecalcote ! Yes, I tested them locally to make sure they work exactly like the MUI icons they are replacing.

I linked my local Sistent build to Meshery UI and temporarily updated ui/components/NameToIcon.tsx to use the new Sistent exports. To verify they render correctly, I temporarily injected the NameToIcon component into the UI to force all 7 icons to display on the screen.

The SVGs render perfectly and properly inherit their color and viewBox properties. Here is the screenshot from my local environment:
Screenshot 2026-03-05 at 9 35 59 PM

@Rajesh-Nagarajan-11
Copy link
Member

Did you know where these icons used in Meshery ui ?

@ashwanisingh011
Copy link
Contributor Author

Did you know where these icons used in Meshery ui ?

Hi @Rajesh-Nagarajan-11! Yes, they are used by ui/components/NameToIcon.tsx for the RJSF form titles. They show up in the configuration panels (like Designs or MeshMap) when a user edits specific Istio/K8s components like VirtualService, Sidecar, or Gateway.

Since triggering them naturally requires a full Istio/K8s local setup, I tested them by temporarily rendering the NameToIcon component inside a standard UI card. I verified that all 7 icons render perfectly and accept the correct colors and sizes!

@Rajesh-Nagarajan-11
Copy link
Member

LGTM! Thanks @ashwanisingh011

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 merged commit 1d760fe into layer5io:master Mar 12, 2026
5 checks passed
@ashwanisingh011 ashwanisingh011 deleted the feat/add-missing-mui-icons branch March 16, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants