feat(icons): add 7 missing material icons for meshery migration#1348
Conversation
Signed-off-by: ashwanisingh011 <ashwanisingh9737@gmail.com>
Signed-off-by: ashwanisingh011 <ashwanisingh9737@gmail.com>
f4abcdd to
38be150
Compare
|
@ashwanisingh011 Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
7fb2103 to
7c99d71
Compare
|
Did you test these icons with the meshery ui ? |
7c99d71 to
2f3de60
Compare
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
Fix lint errors please
… paths Signed-off-by: ashwanisingh011 <ashwanisingh9737@gmail.com>
2f3de60 to
2352349
Compare
|
@ashwanisingh011 have you used these new icons? Have you tested them? |
|
Hi @leecalcote ! Yes, I tested them locally to make sure they work exactly like the MUI icons they are replacing. I linked my local Sistent build to Meshery UI and temporarily updated ui/components/NameToIcon.tsx to use the new Sistent exports. To verify they render correctly, I temporarily injected the NameToIcon component into the UI to force all 7 icons to display on the screen. The SVGs render perfectly and properly inherit their color and viewBox properties. Here is the screenshot from my local environment: |
|
Did you know where these icons used in Meshery ui ? |
Hi @Rajesh-Nagarajan-11! Yes, they are used by ui/components/NameToIcon.tsx for the RJSF form titles. They show up in the configuration panels (like Designs or MeshMap) when a user edits specific Istio/K8s components like VirtualService, Sidecar, or Gateway. Since triggering them naturally requires a full Istio/K8s local setup, I tested them by temporarily rendering the NameToIcon component inside a standard UI card. I verified that all 7 icons render perfectly and accept the correct colors and sizes! |
|
LGTM! Thanks @ashwanisingh011 |
Description
This PR adds 7 missing Material UI SVG icons to the Sistent library.
These icons are required for the ongoing MUI-to-Sistent migration in the Meshery repository, specifically to support the mappings in
ui/components/NameToIcon.tsx.Icons added:
BuildRoundedIconDirectionsCarIconExploreIconFileCopyIconListAltIconSimCardIconSupervisedUserCircleIconRelated Issue: Addresses meshery/meshery# meshery/meshery#17682
Signed commits