Skip to content

Add SyncAltIcon#1430

Merged
saurabhraghuvanshii merged 4 commits intolayer5io:masterfrom
indevi:sync
Apr 27, 2026
Merged

Add SyncAltIcon#1430
saurabhraghuvanshii merged 4 commits intolayer5io:masterfrom
indevi:sync

Conversation

@indevi
Copy link
Copy Markdown
Contributor

@indevi indevi commented Apr 24, 2026

Notes for Reviewers

This PR fixes #1417

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the SyncAltIcon component, including its implementation, export, and integration into the main icons index. Feedback suggests improving the accessibility of the SVG by explicitly rendering a <title> element and setting the role attribute to img when a title is provided.

Comment thread src/icons/SyncAlt/SyncAltIcon.tsx
@suttonskate
Copy link
Copy Markdown
Member

@indevi you need to address the review comments.

indevi added 2 commits April 25, 2026 09:45
Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>
@indevi
Copy link
Copy Markdown
Contributor Author

indevi commented Apr 25, 2026

@suttonskate thanks i have added the required title

Copy link
Copy Markdown
Contributor

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii
Copy link
Copy Markdown
Member

@indevi lint failing please address

@saurabhraghuvanshii saurabhraghuvanshii merged commit eae6c2e into layer5io:master Apr 27, 2026
3 of 5 checks passed
@saurabhraghuvanshii
Copy link
Copy Markdown
Member

thanks @indevi lgtm!!, can you raise another Pr to address lint checks?

@indevi
Copy link
Copy Markdown
Contributor Author

indevi commented Apr 28, 2026

@saurabhraghuvanshii i will need some context on where to see these lint checks. Please provide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]Add SyncAlt icon

4 participants