feat: add SettingsCellIcon to sistent icons#1440
Merged
saurabhraghuvanshii merged 5 commits intolayer5io:masterfrom Apr 27, 2026
Merged
feat: add SettingsCellIcon to sistent icons#1440saurabhraghuvanshii merged 5 commits intolayer5io:masterfrom
saurabhraghuvanshii merged 5 commits intolayer5io:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the SettingsCellIcon component along with its corresponding export files. The review feedback suggests refining the SVG path data by rounding imprecise coordinates to ensure better alignment on the grid and adding trailing newlines to the newly created files for consistency.
| ); | ||
| }; | ||
|
|
||
| export default SettingsCellIcon; No newline at end of file |
Contributor
There was a problem hiding this comment.
| @@ -0,0 +1 @@ | |||
| export { default as SettingsCellIcon } from './SettingsCellIcon'; No newline at end of file | |||
Contributor
There was a problem hiding this comment.
The file is missing a trailing newline. It is recommended to include a newline at the end of the file for consistency and to follow standard formatting practices.
Suggested change
| export { default as SettingsCellIcon } from './SettingsCellIcon'; | |
| export { default as SettingsCellIcon } from './SettingsCellIcon'; | |
4a7112e to
8688a70
Compare
Signed-off-by: RajGajjar-01 <irajgajjar.2004@gmail.com>
8688a70 to
bb2f86a
Compare
Signed-off-by: RajGajjar-01 <irajgajjar.2004@gmail.com>
1e2c437 to
e40ff2f
Compare
kishore08-07
approved these changes
Apr 27, 2026
Contributor
kishore08-07
left a comment
There was a problem hiding this comment.
Thanks @RajGajjar-01 , LGTM @saurabhraghuvanshii
saurabhraghuvanshii
approved these changes
Apr 27, 2026
Member
|
thanks @RajGajjar-01 lgtm!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1421
Notes for Reviewers
This PR fixes the issue by adding the settings cell icon in the relevant component.
Signed commits