Skip to content

feat: add SettingsCellIcon to sistent icons#1440

Merged
saurabhraghuvanshii merged 5 commits intolayer5io:masterfrom
RajGajjar-01:feat/add-settings-cell-icon
Apr 27, 2026
Merged

feat: add SettingsCellIcon to sistent icons#1440
saurabhraghuvanshii merged 5 commits intolayer5io:masterfrom
RajGajjar-01:feat/add-settings-cell-icon

Conversation

@RajGajjar-01
Copy link
Copy Markdown

@RajGajjar-01 RajGajjar-01 commented Apr 25, 2026

Closes #1421

Notes for Reviewers

This PR fixes the issue by adding the settings cell icon in the relevant component.

Signed commits

  • Yes, I signed my commits.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the SettingsCellIcon component along with its corresponding export files. The review feedback suggests refining the SVG path data by rounding imprecise coordinates to ensure better alignment on the grid and adding trailing newlines to the newly created files for consistency.

Comment thread src/icons/SettingsCell/SettingsCellIcon.tsx Outdated
);
};

export default SettingsCellIcon; No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file is missing a trailing newline. Adding a newline at the end of the file is a standard practice that ensures compatibility with various tools and maintains consistency with other files in the repository.

Suggested change
export default SettingsCellIcon;
export default SettingsCellIcon;

Comment thread src/icons/SettingsCell/index.ts Outdated
@@ -0,0 +1 @@
export { default as SettingsCellIcon } from './SettingsCellIcon'; No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file is missing a trailing newline. It is recommended to include a newline at the end of the file for consistency and to follow standard formatting practices.

Suggested change
export { default as SettingsCellIcon } from './SettingsCellIcon';
export { default as SettingsCellIcon } from './SettingsCellIcon';

@RajGajjar-01 RajGajjar-01 force-pushed the feat/add-settings-cell-icon branch 2 times, most recently from 4a7112e to 8688a70 Compare April 25, 2026 18:54
Signed-off-by: RajGajjar-01 <irajgajjar.2004@gmail.com>
@RajGajjar-01 RajGajjar-01 force-pushed the feat/add-settings-cell-icon branch from 8688a70 to bb2f86a Compare April 25, 2026 18:58
@RajGajjar-01 RajGajjar-01 force-pushed the feat/add-settings-cell-icon branch from 1e2c437 to e40ff2f Compare April 26, 2026 12:52
Copy link
Copy Markdown
Contributor

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii saurabhraghuvanshii merged commit c71e33b into layer5io:master Apr 27, 2026
2 checks passed
@saurabhraghuvanshii
Copy link
Copy Markdown
Member

thanks @RajGajjar-01 lgtm!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]Add SettingsCell icon

3 participants