Address Barchart icon#1452
Merged
saurabhraghuvanshii merged 3 commits intolayer5io:masterfrom Apr 29, 2026
Merged
Conversation
Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new BarchartIcon component and integrates it into the icons library. The review identified a module resolution error in the Barchart index file and a copy-paste error in the data-testid attribute of the SVG element.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: shivam tyagi <tyagishivam.dev@gmail.com>
kishore08-07
approved these changes
Apr 29, 2026
Contributor
kishore08-07
left a comment
kishore08-07
left a comment
There was a problem hiding this comment.
Thanks @indevi , LGTM @saurabhraghuvanshii
saurabhraghuvanshii
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1446
Signed commits