[Icon] Add CloudUploadIcon to Sistent#1469
Merged
saurabhraghuvanshii merged 4 commits intolayer5io:masterfrom May 3, 2026
Merged
[Icon] Add CloudUploadIcon to Sistent#1469saurabhraghuvanshii merged 4 commits intolayer5io:masterfrom
saurabhraghuvanshii merged 4 commits intolayer5io:masterfrom
Conversation
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the CloudUploadIcon component along with its corresponding export files. The review feedback suggests improving the SVG's robustness by ensuring critical attributes like viewBox cannot be overridden via props and enhancing accessibility by conditionally applying role and aria-hidden attributes based on the presence of a title.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rishi Raj <180109771+rishiraj38@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rishi Raj <180109771+rishiraj38@users.noreply.github.com>
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
saurabhraghuvanshii
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1465
Signed commits