Feat/add table chart icon#1475
Merged
Rajesh-Nagarajan-11 merged 3 commits intolayer5io:masterfrom May 4, 2026
Merged
Conversation
Signed-off-by: RajGajjar-01 <irajgajjar.2004@gmail.com>
Signed-off-by: RajGajjar-01 <irajgajjar.2004@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the TableChartIcon component, including its implementation, unit tests, and necessary exports. The feedback suggests updating the default fill value to DEFAULT_FILL_NONE to allow the icon to inherit colors from its parent via currentColor, which improves styling flexibility and consistency with other icon components.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Raj Gajjar <153660066+RajGajjar-01@users.noreply.github.com>
leecalcote
reviewed
May 4, 2026
Member
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
Thanks, @RajGajjar-01. Please share a screenshot of the icon.
Contributor
Author
|
yes @leecalcote 
|
Member
|
@RajGajjar-01 Did you test with layer5 website / meshery ui ? |
Rajesh-Nagarajan-11
approved these changes
May 4, 2026
Contributor
Author
|
No I have not tested it with layer5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1470
Signed commits