Update npm install command to use exact version#1497
Merged
Conversation
Signed-off-by: James <160366376+hortison@users.noreply.github.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dependent-repo bump automation to install @sistent/sistent at the resolved release version (rather than a compatible ^ range) when creating update PRs for Meshery-related repositories.
Changes:
- Switch
npm install @sistent/sistent@^${RELEASE_VERSION}tonpm install @sistent/sistent@${RELEASE_VERSION}across the dependent bump jobs. - Adjust the branch-name semver detection regex used to infer
release_versionforworkflow_runtriggers (currently introduces an anchoring regression).
| if [ -z "$release_version" ]; then | ||
| candidate="$WORKFLOW_HEAD_BRANCH" | ||
| if [[ "$candidate" =~ ^v?[0-9]+\.[0-9]+\.[0-9]+ ]]; then | ||
| if [[ "$candidate" =~ v?[0-9]+\.[0-9]+\.[0-9]+ ]]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits