feat: add animated icons for Configuration, Dashboard, Extension, LifeCycle, and Performance#1583
Merged
Rajesh-Nagarajan-11 merged 7 commits intoMay 26, 2026
Conversation
…eCycle, and Performance Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
…tion Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces interactive hover animations and styling enhancements to several SVG icons, including ConfigurationIcon, DashboardIcon, ExtensionIcon, LifeCycleIcon, and PerformanceIcon. The review feedback highlights three key areas for improvement: avoiding module-level side effects in ConfigurationIcon to support tree-shaking and SSR, ensuring proper cleanup of the animationend event listener in DashboardIcon's useAnimationTrigger hook to prevent memory leaks, and making the spring physics simulation in PerformanceIcon's useNeedleSpring hook frame-rate independent by calculating actual delta time.
saurabhraghuvanshii
approved these changes
May 26, 2026
rishiraj38
approved these changes
May 26, 2026
… in icon components Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Junnygram
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Sample usage :
Icon.Hover.webm
Signed commits