style(Tooltip): changed tooltip font#834
Closed
Pratik-050 wants to merge 6 commits intolayer5io:masterfrom
Closed
Conversation
Signed-off-by: Pratik Chandra Pal <pratikpal050@gmail.com>
amitamrutiya
requested changes
Dec 3, 2024
Comment on lines
+18
to
+21
| const StyledFontWrapper = styled(Typography)(() => ({ | ||
| fontFamily: ['Qanelas Soft Regular'].join(',') | ||
| })); | ||
|
|
Contributor
There was a problem hiding this comment.
use the typography from the theme. take a theme as a props in the typography
Member
There was a problem hiding this comment.
yes i already told yesterday pass variant not font family
Author
There was a problem hiding this comment.
Hello @amitamrutiya @sudhanshutech here we can't use this approach:
const StyledFontWrapper = styled(Typography)(({theme}) => ({
typography: theme.typography.textH2Regular,
}));
cause the styled component is being imported from the mui library, and the theme tokens are also coming from mui Typography api. So they'll take the default font of MUI which is Roboto.
I've already tried that.
Member
|
Designs, not Patterns. |
Signed-off-by: Pratik Chandra Pal <pratikpal050@gmail.com>
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Signed-off-by: Md Kaif Ansari <amdkaif843@gmail.com>
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Author
|
Problem with merge conflicts. Closing! |
ITACHI161105
pushed a commit
to ITACHI161105/sistent
that referenced
this pull request
Apr 24, 2026
…erage Pulls in the 10 canonical camelCase wire keys added in meshery/schemas PR layer5io#834 (MesheryPattern / Design counts, designType, TeamMember.joinedAt, Schedule.lastRun / nextRun). No source changes in this commit — the consuming flips land in the follow-up. Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
ITACHI161105
pushed a commit
to ITACHI161105/sistent
that referenced
this pull request
Apr 24, 2026
…e 2.K cascade) Completes the Option B Phase 2.K cascade now that meshery/schemas PR layer5io#834 (v1.2.0) publishes the canonical camelCase wire keys. Surgical field-rename only — no behavioural or structural changes. Flips (46 sites across 9 files): • view_count → viewCount (MesheryPattern / Design v1beta3) • download_count → downloadCount (MesheryPattern / Design v1beta3) • clone_count → cloneCount (MesheryPattern / Design v1beta3) • deployment_count → deploymentCount (MesheryPattern / Design v1beta3) • share_count → shareCount (MesheryPattern / Design v1beta3) • design_type → designType (MesheryPattern / Design v1beta3) • joined_at → joinedAt (TeamMember / Team v1beta2) • last_run → lastRun (Schedule v1beta2) • next_run → nextRun (Schedule v1beta2) Intentionally NOT flipped in this PR (documented inline with TODOs): • team_name (src/custom/Workspaces/types.ts) — deferred until meshery-cloud renames the SQL alias on Team; flipping without the server rename would break the wire. • team_ids / team_names (src/custom/TeamTable/TeamTableConfiguration.tsx) — deferred until the meshery-cloud bulk-delete handler lands dual-accept (camel + legacy snake) to avoid a client-only flip breaking the POST body. Refs: meshery/schemas#832 (closed), meshery/schemas#834 (canonical coverage, merged) Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Changed font for the CustomTooltip component.
This PR fixes #
Signed commits