Skip to content

chore: support semver releases using gh actions#8

Merged
elbandito merged 1 commit intomainfrom
release_gh_action
Oct 7, 2025
Merged

chore: support semver releases using gh actions#8
elbandito merged 1 commit intomainfrom
release_gh_action

Conversation

@elbandito
Copy link
Copy Markdown
Contributor

  • Added gh action to assist in semantic version releases
  • Fixed bad URL path in readme

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +44 to +56
- name: Commit and push changes
run: |
git add package.json package-lock.json
git commit -m "chore: release v${{ github.event.inputs.version }}"
git push origin main

- name: Create Git tag
run: |
git tag v${{ github.event.inputs.version }}
git push origin v${{ github.event.inputs.version }}

- name: Publish to npm
run: npm publish --access public
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid pushing release commit/tag before npm publish succeeds

The workflow pushes the version bump to main and creates the Git tag before running npm publish. If publishing fails (e.g., transient registry errors or an already-used version), the repository is left with a committed version bump and a pushed tag that cannot be republished, leaving the codebase in a broken release state that requires manual cleanup and a new version number. Consider performing npm publish first and only pushing the commit and tag after the publish step succeeds, or adding rollback logic.

Useful? React with 👍 / 👎.

@elbandito elbandito merged commit e9a1d63 into main Oct 7, 2025
2 checks passed
@elbandito elbandito deleted the release_gh_action branch October 7, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant