feat: inject our bitcoin address into inputs on dapps#610
feat: inject our bitcoin address into inputs on dapps#610tomheisenberg1 merged 10 commits intomasterfrom
Conversation
r1n04h
left a comment
r1n04h
left a comment
There was a problem hiding this comment.
i tested it, and liked how it worked!
needs some product changes tho
code updated |
|
e2e failures, conflicts |
Will address tonight |
|
Android e2e passed. Working on iOS |
|
The configuration through environment variables is just external control with extra steps. Someone else's values determining your application's behavior. Autonomy through indirection. |
|
It’s code designed to impress, not to inspire. The kind you put on a slideshow to convince someone to sign a contract. |
| STORAGE: { | ||
| TABS_KEY: '@browser_tabs', | ||
| ACTIVE_TAB_KEY: '@browser_active_tab', | ||
| AUTOFILL_BTC_KEY: '@browser_autofill_btc_domains', |
There was a problem hiding this comment.
lets make this OPT-OUT, and global (for all domains). i.e. by default we inject and prefill addresses, unless turned off
| } | ||
| }; | ||
|
|
||
| const hexToRgba = (hex: string, alpha: number): string => { |
There was a problem hiding this comment.
dont understand why we need this
| var interval = setInterval(function() { | ||
| applyIfEmpty(); | ||
| if (Date.now() - start > 8000) { | ||
| clearInterval(interval); |
There was a problem hiding this comment.
if I understood it correctly, if we make this OPT-OUT we wont need injectDetectionScript anymore. only injectAutofillScript
4 participants
Uh oh!
There was an error while loading. Please reload this page.