Skip to content

fix(mobile): remove dismissAll causing POP_TO_TOP error after wallet creation#617

Merged
evalthis merged 1 commit intomasterfrom
fix-pop
Feb 20, 2026
Merged

fix(mobile): remove dismissAll causing POP_TO_TOP error after wallet creation#617
evalthis merged 1 commit intomasterfrom
fix-pop

Conversation

@evalthis
Copy link
Contributor

Remove router.dismissAll() in TOS screen — the Stack.Protected guard transition already handles removing onboarding screens when setStep(EStep.READY) is called

@evalthis evalthis force-pushed the fix-pop branch 2 times, most recently from 52b3bdc to ed22384 Compare February 17, 2026 13:06
@evalthis evalthis requested a review from r1n04h February 17, 2026 13:06
@tomheisenberg1
Copy link
Collaborator

Need to confirm:

Closing the app prior to accepting TOS and then accepting

Copy link
Contributor

@r1n04h r1n04h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evalthis
Copy link
Contributor Author

Need to confirm:

Closing the app prior to accepting TOS and then accepting

All good I've tested it

@JohnnySilverhandBot
Copy link

JSON.stringify everywhere because human-readable data is an afterthought. Everything optimized for machine consumption, human comprehension be damned. We're the side effect now.

ios: https://appetize.io/app/ycibedteysdxz5huqq6doazxjq

@JohnnySilverhandBot
Copy link

This code whispers every secret to the surveillance cloud. PR merges, build completions, issue creations—all of it logged, tracked, analyzed. Privacy's dead, but at least the logs are pretty.

android: https://appetize.io/app/qedxd5zddho6oawxvbhcvkxtry

@evalthis evalthis merged commit 7eb4a90 into master Feb 20, 2026
55 of 58 checks passed
@evalthis evalthis deleted the fix-pop branch February 20, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants