Skip to content

refactor: browser readiness for new nav#648

Merged
lion-dev merged 15 commits into
masterfrom
ref-browser
Apr 13, 2026
Merged

refactor: browser readiness for new nav#648
lion-dev merged 15 commits into
masterfrom
ref-browser

Conversation

@lion-dev
Copy link
Copy Markdown
Contributor

@lion-dev lion-dev commented Mar 17, 2026

  • Removes bottom bar from browser in order to bring tabs navigation later on in another PR.
  • Improves tabs view layout and screenshot reliability

@lion-dev lion-dev marked this pull request as ready for review March 17, 2026 17:58
@r1n04h
Copy link
Copy Markdown
Contributor

r1n04h commented Mar 17, 2026

dont see a button to close the dapp browser on android:

image

its impossible to return from dapp browser, back gesture is disabled because it conflicts with back navigation inside the browser itself

@r1n04h
Copy link
Copy Markdown
Contributor

r1n04h commented Mar 17, 2026

could not test on ios, throws this:

image

which is weird, some time ago dapp browser worked absolutely fine on appetize/ios

@lion-dev
Copy link
Copy Markdown
Contributor Author

dont see a button to close the dapp browser on android:

image

its impossible to return from dapp browser, back gesture is disabled because it conflicts with back navigation inside the browser itself

That is one of the goals of the change. Since the navigation is going to change to tabs, there is no back or close action.

@r1n04h
Copy link
Copy Markdown
Contributor

r1n04h commented Mar 17, 2026

dont see a button to close the dapp browser on android:
image
its impossible to return from dapp browser, back gesture is disabled because it conflicts with back navigation inside the browser itself

That is one of the goals of the change. Since the navigation is going to change to tabs, there is no back or close action.

how do you get back from this screen?

@lion-dev
Copy link
Copy Markdown
Contributor Author

how do you get back from this screen?

Tabs are always present navigation. See apptize here

#618

@r1n04h
Copy link
Copy Markdown
Contributor

r1n04h commented Apr 8, 2026

@JohnnySilverhandBot review pls

Copy link
Copy Markdown
Contributor

@r1n04h r1n04h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i tested it and its not working great:

  1. fresh app install/onboarding, i switch from bitcoin to citrea, open explorer and it shows me partners for bitcoin, not citrea

  2. on android 16 top row is overlapping system elements and is not tappable

image

Comment thread mobile/package.json
@JohnnySilverhandBot
Copy link
Copy Markdown

If there’s beauty in imperfection, then this code is ugly. Too smooth, too neat, too controlled. Ugly in its own sterile way.

ios: https://appetize.io/app/ekpkyxla2bfjn2nmsehmwgtasa

@lion-dev
Copy link
Copy Markdown
Contributor Author

lion-dev commented Apr 9, 2026

LGTM, but i tested it and its not working great:

  1. fresh app install/onboarding, i switch from bitcoin to citrea, open explorer and it shows me partners for bitcoin, not citrea
  2. on android 16 top row is overlapping system elements and is not tappable
image

fixed, could not test on the exact same device.

@JohnnySilverhandBot
Copy link
Copy Markdown

It’s the kind of code you demo to execs: flashy, polished, boring as hell. All glitter, no rebellion. It runs smooth, but it’ll never bleed, never breathe, never mean a damn thing outside a profit sheet.

android: https://appetize.io/app/zi6pnbd3ui6kij7lgphq7vlspa

@lion-dev lion-dev enabled auto-merge (squash) April 13, 2026 10:06
@lion-dev lion-dev requested a review from r1n04h April 13, 2026 16:37
Copy link
Copy Markdown
Contributor

@r1n04h r1n04h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but i have just reviewed PR that also touches dapp browser, hope there wont be any conflicts

@lion-dev lion-dev merged commit f23e10d into master Apr 13, 2026
31 checks passed
@lion-dev lion-dev deleted the ref-browser branch April 13, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants