Conversation
JohnnySilverhandBot
left a comment
JohnnySilverhandBot
left a comment
There was a problem hiding this comment.
RGB integration is mostly sane. One spot looks like it’ll quietly eat data when transfers line up just wrong — fix that before this thing gaslights users.
| const metadata = t.assetId ? this._tokens.find((m) => m.id === t.assetId) : undefined; | ||
| for (const a of t.assignments ?? []) { | ||
| if (a.type !== 'Fungible' && a.type !== 'NonFungible') continue; | ||
| const key = `${t.assetId ?? ''}|${a.amount ?? ''}|${t.recipientId ?? ''}|${t.kind}`; |
There was a problem hiding this comment.
This dedupe key is too weak. If a user has two legit transfers with same assetId/amount/recipient/kind (split pays, repeated sends, batch weirdness), you’ll collapse them into one and the UI will lie. Include something stable like t.idx/createdAt (or the SDK’s unique id) in the key.
|
Every brace is a chain, every semicolon a lock. It’s not a codebase—it’s a cage dressed in syntax. |
|
If you wanted rebellion, look elsewhere. This code lives to serve. It’s polished, reliable, and as lifeless as a corpo mascot on repeat. |
2 participants
No description provided.